bpo-30040: New empty dict uses key-sharing dict. #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@methane, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @rhettinger to be potential reviewers. |
Member
|
You'll need to apply the change in 2757082 to line 5274 and 5276 as well. |
Like dict.clear(). Sizeof new empty dict becomes 72 bytes from 240 bytes (amd64).
As suggested by Mark Shannon in the GitHub review.
methane
force-pushed
the
compact-empty-dict
branch
from
4144fc9 to
b8cbfc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like dict.clear().
Sizeof new empty dict becomes 72 bytes from 240 bytes (amd64).
https://bugs.python.org/issue30040