gh-107995: Fix doctest collection of functools.cached_property objects#107996
gh-107995: Fix doctest collection of functools.cached_property objects#107996AlexWaygood merged 3 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
tjsmart
force-pushed
the
fix-issue-107995
branch
from
4e2f44b to
3d02d97
Compare
tjsmart
force-pushed
the
fix-issue-107995
branch
from
3d02d97 to
da2616d
Compare
tjsmart
force-pushed
the
fix-issue-107995
branch
from
da2616d to
4591a60
Compare
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! You can also add your name to this file here, if you like, but it isn't mandatory: https://github.com/python/cpython/blob/main/Misc/ACKS
|
By the way, for future PRs to CPython, please avoid force-pushing where possible. It interacts badly with the GitHub UI, making it hard for reviewers to see what changed between commits. We merge everything using GitHub's "squash and merge" button in CPython, so we don't care about a messy commit history for a PR :-) |
Sounds good. Thanks for the heads up! 👍 |
5 participants
DocTestFinderwould skipfunctools.cached_propertyobjects because they were not considered to be a part of the module that it is collecting doc tests from. To fix this issue I added a check forcached_propertythat grabs the underlying function, similar to what is done forstaticmethodandclassmethod.