Skip to content

gh-106634: Corrected minor asyncio doc issues#106671

Merged
kumaraditya303 merged 6 commits intopython:mainfrom
Spycho:fix-issue-106634
Jul 13, 2023
Merged

gh-106634: Corrected minor asyncio doc issues#106671
kumaraditya303 merged 6 commits intopython:mainfrom
Spycho:fix-issue-106634

Conversation

@Spycho
Copy link
Copy Markdown
Contributor

@Spycho Spycho commented Jul 12, 2023 •
edited by bedevere-bot
Loading

Corrected AbstractEventLoopPolicy docstring to refer to AbstractEventLoop rather than BaseEventLoop.

Corrected docstring grammar error (it undefined -> it is undefined).

@bedevere-bot bedevere-bot mentioned this pull request Jul 11, 2023
Closed
@ghost
Copy link
Copy Markdown

ghost commented Jul 12, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@methane methane added topic-asyncio stdlib Standard Library Python modules in the Lib/ directory needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 12, 2023
@methane
Copy link
Copy Markdown
Member

methane commented Jul 12, 2023

LGTM.
I wait merging this for a while because other code owner would review and merge this.
Please ping me if no one merge this.

@kumaraditya303 kumaraditya303 merged commit 4b4a5b7 into python:main Jul 13, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 13, 2023

Thanks @Spycho for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 13, 2023

Sorry @Spycho and @kumaraditya303, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 4b4a5b70aa8d47b1e2a0582b741c31b786da762a 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2023
@Spycho @miss-islington
pythongh-106634: Corrected minor asyncio doc issues (pythonGH-106671)
4e60576 
(cherry picked from commit 4b4a5b7)

Co-authored-by: Chris Brett <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 13, 2023

GH-106711 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 13, 2023
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 13, 2023
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 13, 2023

Thanks @Spycho for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 13, 2023

Thanks @Spycho for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2023
@Spycho @miss-islington
pythongh-106634: Corrected minor asyncio doc issues (pythonGH-106671)
a23d99d 
(cherry picked from commit 4b4a5b7)

Co-authored-by: Chris Brett <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 13, 2023

GH-106712 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2023
@Spycho @miss-islington
pythongh-106634: Corrected minor asyncio doc issues (pythonGH-106671)
00c9232 
(cherry picked from commit 4b4a5b7)

Co-authored-by: Chris Brett <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 13, 2023
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 13, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit 4b4a5b7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/5754) and take a look at the build logs.
  4. Check if the failure is related to this commit (4b4a5b7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/5754

Failed tests:

  • test_concurrent_futures

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

415 tests OK.

10 slowest tests:

  • test_math: 5 min 28 sec
  • test_multiprocessing_spawn: 4 min 13 sec
  • test_wmi: 4 min 5 sec
  • test_peg_generator: 2 min 27 sec
  • test_capi: 2 min 20 sec
  • test_tokenize: 2 min 14 sec
  • test_unparse: 1 min 52 sec
  • test_mmap: 1 min 29 sec
  • test_regrtest: 1 min 22 sec
  • test_io: 1 min 18 sec

31 tests skipped:
test.test_asyncio.test_unix_events test_curses test_dbm_gnu
test_dbm_ndbm test_devpoll test_epoll test_fcntl test_fork1
test_gdb test_grp test_ioctl test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_openpty test_perf_profiler
test_perfmaps test_poll test_posix test_pty test_pwd test_readline
test_resource test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64 test_zoneinfo

1 re-run test:
test_concurrent_futures

Total duration: 23 min 2 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\__main__.py", line 2, in <module>
    main()
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 822, in main
    Regrtest().main(tests=tests, **kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 752, in main
    with os_helper.temp_cwd(test_cwd, quiet=True):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 531, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(value)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 485, in temp_dir
    rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 442, in rmtree
    _rmtree(path)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 385, in _rmtree
    _waitfor(_rmtree_inner, path, waitall=True)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 330, in _waitfor
    func(pathname)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 382, in _rmtree_inner
    _force_run(fullname, os.rmdir, fullname)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 218, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_4368�\\test_python_worker_9848�'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 480, in temp_dir
    yield path
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 533, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 758, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\main.py", line 817, in _main
    sys.exit(0)
SystemExit: 0


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\__init__.py", line 207, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_4368�\\test_python_worker_9848�'

@Spycho
Copy link
Copy Markdown
Contributor Author

Spycho commented Jul 13, 2023

I've not worked with Python's buildbot before, and the tests that it runs, but "The process cannot access the file because it is being used by another process" sounds like it's more likely an issue with the test or environment than an issue with these changes. Has anyone seen that error before? Is it something that happens sporadically?

kumaraditya303 pushed a commit that referenced this pull request Jul 14, 2023
@miss-islington @Spycho
[3.12] gh-106634: Corrected minor asyncio doc issues (GH-106671) (#10…
dfdded6 
…6712)

gh-106634: Corrected minor asyncio doc issues (GH-106671)
(cherry picked from commit 4b4a5b7)

Co-authored-by: Chris Brett <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request Jul 29, 2023
@miss-islington @Spycho
[3.11] gh-106634: Corrected minor asyncio doc issues (GH-106671) (#10…
ddccdbf 
…6711)

gh-106634: Corrected minor asyncio doc issues (GH-106671)
(cherry picked from commit 4b4a5b7)

Co-authored-by: Chris Brett <[email protected]>
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Spycho @methane @miss-islington @bedevere-bot @kumaraditya303 @ZeroIntensity @AlexWaygood