gh-105140: remove unused arg of _PyErr_ChainStackItem#105141
Merged
iritkatriel merged 4 commits intopython:mainfrom Jun 1, 2023
Merged
gh-105140: remove unused arg of _PyErr_ChainStackItem#105141iritkatriel merged 4 commits intopython:mainfrom
iritkatriel merged 4 commits intopython:mainfrom
Conversation
iritkatriel
added
the
interpreter-core
vstinner
approved these changes
Jun 1, 2023
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM since tests still pass and i'm confident that gen_send_ex2() is tested by the Python test suite.
| @@ -0,0 +1 @@ | |||
| Remove unused, untested and undocumented arg of ``_PyErr_ChainStackItem``. | |||
Member
There was a problem hiding this comment.
I don't think that end users care about changes in the internal C API. You can remove this NEWS entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105140.