gh-104341: Fix threading Module Shutdown#104560
Draft
ericsnowcurrently wants to merge 12 commits intopython:mainfrom
Draft
gh-104341: Fix threading Module Shutdown#104560ericsnowcurrently wants to merge 12 commits intopython:mainfrom
ericsnowcurrently wants to merge 12 commits intopython:mainfrom
Conversation
Comment on lines
+86
to
+92
| PyThread_acquire_lock(threads->mutex, WAIT_LOCK); | ||
| while (threads->head != NULL) { | ||
| PyThread_release_lock(threads->mutex); | ||
| // XXX Sleep? | ||
| PyThread_acquire_lock(threads->mutex, WAIT_LOCK); | ||
| } | ||
| PyThread_release_lock(threads->mutex); |
Member
Author
There was a problem hiding this comment.
FYI, this doesn't feel right. I'm going to look at what my options are. A condvar would work, but that doesn't seem to be something we do in CPython outside the GIL.
(I'm also open to ideas.)
Member
Author
There was a problem hiding this comment.
I've come up with a slightly better approach.
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 51d960e 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
adr26
reviewed
May 16, 2023
| static struct PyModuleDef thread_module; | ||
|
|
||
|
|
||
| /* threads owned by the modulo */ |
Member
Author
|
FTR, I ran the buildbots on commit 51d960e: https://buildbot.python.org/all/#/changes/22637. |
Member
Author
Member
Author
CI run 112 test modules failed before the CI job was canceled. (details)test module timed out after 20 minutes (1200s):
individual tests timed out:
still running:
CI run 212 test modules failed before the CI job was canceled. (details)test module timed out after 20 minutes (1200s):
individual tests timed out:
still running:
Buildbot (ARM64 macOS PR)25 test modules failed (details)test module timed out after 15 minutes (900s):
individual tests timed out:
|
Member
|
I reran the job and got the same result (the tests are not done yet but started to time out already). |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the frequent crashes in test_threading and test__xxsubinterpreters.
There is some duplication with the threading module which could be removed after this lands. We can also eliminate
PyThreadState.on_deleteandPyInterpreterState.threads.count, both of which are cases where the state of the threading module leaked out into the runtime.(Also see gh-63008 and gh-18296.)