-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30455: Generate all token related code and docs from Grammar/Tokens. #10370
Merged
serhiy-storchaka
merged 25 commits into
python:master
from
serhiy-storchaka:regen-token2
Dec 22, 2018
Merged
bpo-30455: Generate all token related code and docs from Grammar/Tokens. #10370
serhiy-storchaka
merged 25 commits into
python:master
from
serhiy-storchaka:regen-token2
Dec 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
If there are no objections I am going to merge this PR in few days. |
vstinner
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have a very minor suggestion.
@@ -1,13 +1,6 @@ | |||
#! /usr/bin/env python3 | |||
|
|||
"""Non-terminal symbols of Python grammar (from "graminit.h").""" | |||
|
|||
# This file is automatically generated; please don't muck it up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe document which tool generates it.
gvanrossum
added a commit
to gvanrossum/cpython
that referenced
this pull request
Jan 25, 2019
Grammar changes merged: - PEP 572 (assignment expessions) - pythonGH-10370 (slightly more lenient r.h.s. for annotated assignments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30455