Skip to content

gh-102110: Updated cpython/Tools/README#103111

Closed
jojo-jupiter wants to merge 6 commits intopython:mainfrom
jojo-jupiter:patch-1
Closed

gh-102110: Updated cpython/Tools/README#103111
jojo-jupiter wants to merge 6 commits intopython:mainfrom
jojo-jupiter:patch-1

Conversation

@jojo-jupiter
Copy link
Copy Markdown

@jojo-jupiter jojo-jupiter commented Mar 29, 2023 •
edited
Loading

gh-102110: Updated current cpython/Tools subdirectories and descriptions in README.

Added all cpython/Tools subdirectories to the README and included descriptions for the following subdirectories:

  • c-analyzer
  • cases_generator
  • importbench
  • nuget
  • wasm

@jojo-jupiter
Update cpython/Tools/README
afa0425 
Added all cpython/Tools modules to the README and included descriptions for the following modules:
- c-analyzer
- cases_generator
- importbench
- nuget
- wasm

*Question: Should we remove the parser module from README? I do not see it listed in cpython/Tools anymore.
@ghost
Copy link
Copy Markdown

ghost commented Mar 29, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 29, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@jojo-jupiter jojo-jupiter changed the title Update cpython/Tools/README gh-102110: Updated cpython/Tools/README Mar 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 29, 2023
Closed
@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Mar 30, 2023

According to ...s in the changes, the PR is in progress. Probably you should convert it into a draft to not confuse reviewers.

@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Mar 30, 2023

Or just delete these lines since Several modules still require descriptions in the news entry covers it.

@jojo-jupiter
Copy link
Copy Markdown
Author

jojo-jupiter commented Mar 30, 2023

According to ...s in the changes, the PR is in progress. Probably you should convert it into a draft to not confuse reviewers.
Or just delete these lines since Several modules still require descriptions in the news entry covers it.

Thank you for your feedback! I will convert this PR to a draft and make the changes you suggested.

@jojo-jupiter jojo-jupiter marked this pull request as draft March 30, 2023 12:26
@jojo-jupiter
Update README
b21b51c 
Provided descriptions for the remaining modules. Removed parser from README, as this module no longer exists in cpython/Tools.
@jojo-jupiter
Update README
6d0b153
@jojo-jupiter
Update 2023-03-29-14-09-19.gh-issue-102110.TrxywJ.rst
761cf56
@jojo-jupiter jojo-jupiter marked this pull request as ready for review March 30, 2023 15:08
@jojo-jupiter
Copy link
Copy Markdown
Author

jojo-jupiter commented Mar 30, 2023 •
edited
Loading

gh-102110: Updated cpython/Tools/README to include descriptions for all current modules in cpython/Tools.

Added descriptions for the folllowing cpython/Tools modules to cpython/Tools/README:

  • build
  • clinic
  • patchcheck
  • ssl
  • tz
  • c-analyzer
  • cases_generator
  • importbench
  • nuget
  • wasm

Removed parser from README, as this module no longer exists in cpython/Tools.

@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Mar 30, 2023

@TylerBurgee Please ping me if nobody reviews this PR until next Friday so I could ping all active developers affected for review:

  • ericsnowcurrently (build and c-analyzer)
  • gvanrossum (cases-generator)
  • erlend-aasland (clinic)
  • zooba (nuget)
  • zware (patchcheck)
  • vstinner (wasm)

@jojo-jupiter
Copy link
Copy Markdown
Author

jojo-jupiter commented Mar 30, 2023

@arhadthedev Okay, will do!

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Mar 30, 2023

Thank you for the PR, however there were already two open PRs for this listed on the issue:

Sorry for any mixup, I suggest next time picking something that doesn't already have open PRs.

@hugovk hugovk closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jojo-jupiter @bedevere-bot @arhadthedev @hugovk