Skip to content

bpo-34523: Fix config_init_fs_encoding() for ASCII #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 30, 2018
Merged

bpo-34523: Fix config_init_fs_encoding() for ASCII #10232

vstinner merged 1 commit into from
Oct 30, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 30, 2018 •
edited by bedevere-bot
Loading

  • bpo-34523, bpo-34403: Fix config_init_fs_encoding(): it now uses
    ASCII if _Py_GetForceASCII() is true.
  • Fix a regression of commit b2457ef.
  • Fix also a memory leak: get_locale_encoding() already allocates
    memory, no need to duplicate the string.

https://bugs.python.org/issue34523

@vstinner
bpo-34523: Fix config_init_fs_encoding() for ASCII
e35ec5c 
* bpo-34523, bpo-34403: Fix config_init_fs_encoding(): it now uses
  ASCII if _Py_GetForceASCII() is true.
* Fix a regression of commit b2457ef.
* Fix also a memory leak: get_locale_encoding() already allocates
  memory, no need to duplicate the string.
@vstinner vstinner merged commit 905f1ac into python:master Oct 30, 2018
@vstinner vstinner deleted the force_ascii branch October 30, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot