bpo-33944: note about the intended use of code in .pth files#10131
bpo-33944: note about the intended use of code in .pth files#10131miss-islington merged 3 commits intopython:masterfrom
Conversation
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I highly approve of augmenting the doc as an alternative to deprecating this useful feature. With one optional suggestion, the text looks good according to the discussion. Another core dev should approve and commit.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
|
Sorry, I can't merge this PR. Reason: |
|
Thanks @native-api for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…H-10131) https://bugs.python.org/issue33944 (cherry picked from commit f9b5840) Co-authored-by: native-api <[email protected]>
|
GH-15942 is a backport of this pull request to the 3.8 branch. |
… (GH-15942) https://bugs.python.org/issue33944 (cherry picked from commit f9b5840) Co-authored-by: native-api <[email protected]>
6 participants
https://bugs.python.org/issue33944
Automerge-Triggered-By: @matrixise