gh-90104: avoid RecursionError on recursive dataclass field repr by carljm · Pull Request #100756 · python/cpython

carljm · 2023-01-04T22:08:02Z

Issue: RecursionError when annotating a field with the same name as a field #90104

hauntsaninja

Thank you!

ericvsmith · 2023-01-05T12:44:46Z

Lib/test/test_dataclasses.py

+        rec_field.type = rec_field
+        rec_field.name = "id"
+        repr_output = repr(rec_field)
+        expected_output = "Field(name='id',type=...," \


I think I'd just test that "type=..." is in the repr, not for the rest of the values. If new ones are added, this test would need to be modified.

Also, I think an additional test for the original problem:

@dataclass class D: C: C = field()

would be good.

Otherwise looks good!

And to be clear: I'd just add the second test to make sure it doesn't raise RecursionError, I wouldn't go nuts on testing the exact output.

Let me know if the assertion in the new test qualifies as "going nuts" -- just seemed easy to check, and more confusing to have a test with no assertions at all.

Maybe "go nuts" wasn't the best wording to use 😃. Your change is exactly what I would have done, down to the commas, so I think it's perfect. Thanks!

* main: pythonGH-100288: Remove LOAD_ATTR_METHOD_WITH_DICT instruction. (pythonGH-100753) pythonGH-100766: Note that locale.LC_MESSAGES is not universal (pythonGH-100702) Drop myself from pathlib maintenance (python#100757) pythongh-100739: Respect mock spec when checking for unsafe prefixes (python#100740)

miss-islington · 2023-01-06T00:19:44Z

Thanks @carljm for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington · 2023-01-06T00:19:48Z

Sorry, @carljm and @ericvsmith, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0a7936a38f0bab1619ee9fe257880a51c9d839d5 3.11

miss-islington · 2023-01-06T00:19:51Z

Sorry @carljm and @ericvsmith, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 0a7936a38f0bab1619ee9fe257880a51c9d839d5 3.10

bedevere-bot · 2023-01-06T01:09:50Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 0a7936a.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/3235) and take a look at the build logs.
Check if the failure is related to this commit (0a7936a) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/3235

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

test_venv: 6 min 48 sec
test_largefile: 6 min 47 sec
test_multiprocessing_spawn: 4 min 44 sec
test_concurrent_futures: 3 min 16 sec
test_ctypes: 3 min 13 sec
test_zipfile: 3 min 3 sec
test_asyncio: 2 min 53 sec
test_pyclbr: 2 min 40 sec
test_multiprocessing_forkserver: 1 min 57 sec
test_tokenize: 1 min 54 sec

1 test altered the execution environment:
test_multiprocessing_fork

21 tests skipped:
test_check_c_globals test_devpoll test_idle test_ioctl test_kqueue
test_launcher test_msilib test_peg_generator test_perf_profiler
test_startfile test_tcl test_tix test_tkinter test_ttk
test_ttk_textonly test_turtle test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

Total duration: 30 min 7 sec

Click to see traceback logs

remote: Enumerating objects: 11, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  11% (1/9)        
remote: Compressing objects:  22% (2/9)        
remote: Compressing objects:  33% (3/9)        
remote: Compressing objects:  44% (4/9)        
remote: Compressing objects:  55% (5/9)        
remote: Compressing objects:  66% (6/9)        
remote: Compressing objects:  77% (7/9)        
remote: Compressing objects:  88% (8/9)        
remote: Compressing objects: 100% (9/9)        
remote: Compressing objects: 100% (9/9), done.        
remote: Total 11 (delta 1), reused 2 (delta 1), pack-reused 1        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '0a7936a38f0bab1619ee9fe257880a51c9d839d5'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 0a7936a38f gh-90104: avoid RecursionError on recursive dataclass field repr (gh-100756)
Switched to and reset branch 'main'

Objects/obmalloc.c:776:1: warning: ‘always_inline’ function might not be inlinable [-Wattributes]
  776 | arena_map_get(pymem_block *p, int create)
      | ^~~~~~~~~~~~~

make: *** [Makefile:1906: buildbottest] Error 3

carljm · 2023-01-06T01:18:30Z

On the failing buildbot, test_multiprocessing_fork left behind a temporary file. That seems pretty likely a false positive, doesn't seem like it could be caused by this PR.

carljm · 2023-01-06T01:18:50Z

I'll put up manual backport PRs since the auto-backporting failed.

ericvsmith · 2023-01-06T01:38:05Z

I'll put up manual backport PRs since the auto-backporting failed.

Thanks. I had started looking at doing this, but I'm having some issue with cherry_picker. I'm sure I'm doing something stupid.

On the failing buildbot, test_multiprocessing_fork left behind a temporary file. That seems pretty likely a false positive, doesn't seem like it could be caused by this PR.

Agreed.

bedevere-bot · 2023-01-06T01:42:29Z

GH-100784 is a backport of this pull request to the 3.11 branch.

…eld repr (pythongh-100756) Avoid RecursionError on recursive dataclass field repr (cherry picked from commit 0a7936a)

bedevere-bot · 2023-01-06T01:46:26Z

GH-100785 is a backport of this pull request to the 3.10 branch.

…pr (gh-100756) (GH-100784) Avoid RecursionError on recursive dataclass field repr (cherry picked from commit 0a7936a) Automerge-Triggered-By: GH:ericvsmith

…pr (gh-100756) (GH-100785) Avoid RecursionError on recursive dataclass field repr (cherry picked from commit 0a7936a) Automerge-Triggered-By: GH:ericvsmith

pythongh-90104: avoid RecursionError on recursive dataclass field repr

1f9d541

carljm requested a review from ericvsmith as a code owner January 4, 2023 22:08

bedevere-bot added the awaiting review label Jan 4, 2023

bedevere-bot mentioned this pull request Jan 4, 2023

RecursionError when annotating a field with the same name as a field #90104

Closed

📜🤖 Added by blurb_it.

7241045

hauntsaninja approved these changes Jan 5, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jan 5, 2023

hauntsaninja added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 5, 2023

ericvsmith reviewed Jan 5, 2023

View reviewed changes

carljm added 2 commits January 5, 2023 07:18

Review comments

6ba4f3d

ericvsmith merged commit 0a7936a into python:main Jan 6, 2023

bedevere-bot removed the awaiting merge label Jan 6, 2023

miss-islington assigned ericvsmith Jan 6, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 6, 2023

carljm added a commit to carljm/cpython that referenced this pull request Jan 6, 2023

[3.11] pythongh-90104: avoid RecursionError on recursive dataclass fi…

ccf149b

…eld repr (pythongh-100756) Avoid RecursionError on recursive dataclass field repr (cherry picked from commit 0a7936a)

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 6, 2023

Uh oh!

Conversation

carljm commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hauntsaninja left a comment

Choose a reason for hiding this comment

Uh oh!

ericvsmith Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

ericvsmith Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

carljm Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

ericvsmith Jan 5, 2023

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jan 6, 2023

Uh oh!

miss-islington commented Jan 6, 2023

Uh oh!

miss-islington commented Jan 6, 2023

Uh oh!

bedevere-bot commented Jan 6, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

carljm commented Jan 6, 2023

Uh oh!

carljm commented Jan 6, 2023

Uh oh!

ericvsmith commented Jan 6, 2023

Uh oh!

bedevere-bot commented Jan 6, 2023

Uh oh!

bedevere-bot commented Jan 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

carljm commented Jan 4, 2023 •

edited

Loading