Skip to content

Comments

gh-100001: Omit control characters in http.server stderr logs.#100002

Merged
gpshead merged 9 commits intopython:mainfrom
gpshead:security/http.server/log
Dec 5, 2022
Merged

gh-100001: Omit control characters in http.server stderr logs.#100002
gpshead merged 9 commits intopython:mainfrom
gpshead:security/http.server/log

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Dec 5, 2022 •
edited
Loading

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.

@gpshead gpshead self-assigned this Dec 5, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2022
Closed
@gpshead gpshead marked this pull request as ready for review December 5, 2022 10:17
vstinner
vstinner reviewed Dec 5, 2022
View reviewed changes
Yhg1s
Yhg1s reviewed Dec 5, 2022
View reviewed changes
@gpshead gpshead merged commit d8ab0a4 into python:main Dec 5, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2022

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2022

Sorry @gpshead, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d8ab0a4dfa48f881b4ac9ab857d2e9de42f72828 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@gpshead @miss-islington
pythongh-100001: Omit control characters in http.server stderr logs. (p…
a241ad1 
…ythonGH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2022

GH-100031 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 5, 2022
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2022

GH-100032 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@gpshead @miss-islington
pythongh-100001: Omit control characters in http.server stderr logs. (p…
4ba9434 
…ythonGH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2022

GH-100033 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2022

GH-100034 is a backport of this pull request to the 3.7 branch.

@gpshead gpshead added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Dec 5, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2022

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@gpshead @miss-islington
pythongh-100001: Omit control characters in http.server stderr logs. (p…
43bb1c2 
…ythonGH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2022

GH-100035 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@gpshead @miss-islington
pythongh-100001: Omit control characters in http.server stderr logs. (p…
69f5f37 
…ythonGH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
@gpshead gpshead deleted the security/http.server/log branch December 5, 2022 21:01
miss-islington added a commit that referenced this pull request Dec 5, 2022
@miss-islington @gpshead
gh-100001: Omit control characters in http.server stderr logs. (GH-10…
ec8c06b 
…0002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Dec 5, 2022
@miss-islington @gpshead
gh-100001: Omit control characters in http.server stderr logs. (GH-10…
a726f74 
…0002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
ned-deily pushed a commit that referenced this pull request Dec 5, 2022
@miss-islington @gpshead
[3.7] gh-100001: Omit control characters in http.server stderr logs. (G…
b5bdf6a 
…H-100002) (GH-100034)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>
ambv pushed a commit that referenced this pull request Dec 6, 2022
@miss-islington @gpshead
[3.8] gh-100001: Omit control characters in http.server stderr logs. (G…
e43393a 
…H-100002) (#100033)

* gh-100001: Omit control characters in http.server stderr logs. (GH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>

* also escape \s (backport of PR #100038).

* add versionadded and remove extraneous 'to'

Co-authored-by: Gregory P. Smith <[email protected]>
ambv pushed a commit that referenced this pull request Dec 6, 2022
@miss-islington @gpshead
[3.9] gh-100001: Omit control characters in http.server stderr logs. (G…
3b81c13 
…H-100002) (#100032)

* gh-100001: Omit control characters in http.server stderr logs. (GH-100002)

Replace control characters in http.server.BaseHTTPRequestHandler.log_message with an escaped \xHH sequence to avoid causing problems for the terminal the output is printed to.
(cherry picked from commit d8ab0a4)

Co-authored-by: Gregory P. Smith <[email protected]>

* also escape \s (backport of PR #100038).

* add versionadded and remove extra 'to'

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@Yhg1s Yhg1s Yhg1s left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@gpshead gpshead

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gpshead @miss-islington @bedevere-bot @vstinner @Yhg1s