Skip to content

Conversation

@brettcannon
Copy link
Member

No description provided.

node = nodes.strong(text, text)
return [node]
content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\b ? I think you overwrote the \1 :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right. Now fixed.

Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.

ISSUE_URI = 'https://bugs.python.org/issue%s'
SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s'
SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be master rather than 3.6 on this branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and updated here since I'm already changing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

node = nodes.strong(text, text)
return [node]
content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@zware zware merged commit 79ab8be into master Feb 10, 2017
@brettcannon brettcannon deleted the bpo-news-support branch February 10, 2017 23:10
Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017
(cherry picked from commit 79ab8be)
Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017
Change the url to 3.5

(cherry picked from commit 79ab8be)

# Conflicts:
#	Doc/tools/extensions/pyspecific.py
Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017
Change the url to 2.7

(cherry picked from commit 79ab8be)
Mariatta added a commit that referenced this pull request Feb 12, 2017
…#44)

* Support "bpo-" in Misc/NEWS (#1)
Change the url to 2.7

(cherry picked from commit 79ab8be)

* pyspecific.py: remove space after` bpo-`
Mariatta added a commit that referenced this pull request Feb 13, 2017
Change the url to 3.5

(cherry picked from commit 79ab8be)

Contributed by Brett Cannon
tiran pushed a commit that referenced this pull request Aug 28, 2017
* Added support for CAN_ISOTP protocol

* Added unit tests for CAN ISOTP

* Updated documentation for ISO-TP protocol

* Removed trailing whitespace in documentation

* Added blurb NEWS.d file

* updated Misc/ACKS

* Fixed broken unit test that was using isotp const outside of skippable section

* Removed dependecy over third party project

* Added implementation for getsockname + unit tests

* Missing newline at end of ACKS file

* Accidentally inserted a type in ACKS file

* Followed tiran changes review #1 recommendations

* Added spaces after comma
GadgetSteve referenced this pull request in GadgetSteve/cpython Sep 10, 2017
* Added support for CAN_ISOTP protocol

* Added unit tests for CAN ISOTP

* Updated documentation for ISO-TP protocol

* Removed trailing whitespace in documentation

* Added blurb NEWS.d file

* updated Misc/ACKS

* Fixed broken unit test that was using isotp const outside of skippable section

* Removed dependecy over third party project

* Added implementation for getsockname + unit tests

* Missing newline at end of ACKS file

* Accidentally inserted a type in ACKS file

* Followed tiran changes review #1 recommendations

* Added spaces after comma
native-api pushed a commit to native-api/cpython that referenced this pull request Jun 5, 2018
barneygale added a commit to barneygale/cpython that referenced this pull request Oct 29, 2024
barneygale added a commit to barneygale/cpython that referenced this pull request Mar 19, 2025
eyzmeng pushed a commit to rapidcow/cpython that referenced this pull request Dec 8, 2025
Kaushalt2004 added a commit to Kaushalt2004/cpython that referenced this pull request Dec 22, 2025
Kaushalt2004 added a commit to Kaushalt2004/cpython that referenced this pull request Dec 25, 2025
…new__ override, rely on __add__ only. Clarify with reviewer note. (python#1 branch)
Krishna-web-hub added a commit to Krishna-web-hub/cpython that referenced this pull request Jan 15, 2026
Krishna-web-hub added a commit to Krishna-web-hub/cpython that referenced this pull request Jan 18, 2026
Co-authored-by: Bénédikt Tran <[email protected]>
SonicField added a commit to SonicField/cpython that referenced this pull request Jan 19, 2026
Add timing for all intermediate GC phases to diagnose the 50-80ms gap
between timed phases and total gc.collect() time.

New timing fields:
- scan_heap_ns: parallel scan_heap phase
- disable_deferred_ns: disable deferred refcounting loop
- find_weakrefs_ns: find_weakref_callbacks
- stw1_ns: StartTheWorld python#1
- objs_decref_ns: cleanup_worklist(objs_to_decref)
- weakref_callbacks_ns: call_weakref_callbacks
- finalize_ns: finalize_garbage
- stw2_ns: StopTheWorld python#2
- resurrection_ns: handle_resurrected_objects
- freelists_ns: _PyGC_ClearAllFreeLists
- clear_weakrefs_ns: clear_weakrefs
- stw3_ns: StartTheWorld python#3

All values exposed via gc.get_parallel_stats()['phase_timing'].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants