-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
IsolatedAsyncioTestCase calls _setupAsyncioRunner even for skipped tests #96030
Copy link
Copy link
Closed
Labels
pendingThe issue will be closed if no feedback is providedThe issue will be closed if no feedback is providedtestsTests in the Lib/test dirTests in the Lib/test dirtopic-asynciotype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
TestCase.run() is always executed, even for skipped tests. In fact the method checks for skipped and expected failure markers. The implementation of IsolatedAsyncioTestCase.run runs additional code around TestCase.run that does not obey the skipped marker. This was first discovered when GH-95736 broke tests on wasm32-emscripten. _setupAsyncioRunner should not be called if a test method or class is marked as skipped.
I have an easy fix for the issue.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
pendingThe issue will be closed if no feedback is providedThe issue will be closed if no feedback is providedtestsTests in the Lib/test dirTests in the Lib/test dirtopic-asynciotype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Projects
Status
Done
Status
Done