Don't raise TimeoutError if the CancelledError was swallowed by inner code

asvetlov · asvetlov · commit e8c67cef3741 · 2022-03-10T01:48:35.000+02:00
diff --git a/Lib/asyncio/timeouts.py b/Lib/asyncio/timeouts.py
@@ -92,9 +92,7 @@ async def __aexit__(
         if self._state is _State.EXPIRING:
             self._state = _State.EXPIRED
 
-            if (self._task.uncancel() == 0
-                and exc_type in (None, exceptions.CancelledError)
-            ):
+            if self._task.uncancel() == 0 and exc_type is exceptions.CancelledError:
                 # Since there are no outstanding cancel requests, we're
                 # handling this.
                 raise TimeoutError
diff --git a/Lib/test/test_asyncio/test_timeouts.py b/Lib/test/test_asyncio/test_timeouts.py
@@ -45,21 +45,33 @@ async def test_timeout_at_basic(self):
         self.assertEqual(deadline, cm.when())
 
     async def test_nested_timeouts(self):
-        cancel = False
+        loop = asyncio.get_running_loop()
+        cancelled = False
         with self.assertRaises(TimeoutError):
-            async with asyncio.timeout(0.01) as cm1:
+            deadline = loop.time() + 0.01
+            async with asyncio.timeout_at(deadline) as cm1:
                 # Only the topmost context manager should raise TimeoutError
-                with self.assertRaises(asyncio.CancelledError):
-                    async with asyncio.timeout(0.01) as cm2:
+                try:
+                    async with asyncio.timeout_at(deadline) as cm2:
                         await asyncio.sleep(10)
+                except asyncio.CancelledError:
+                    cancelled = True
+                    raise
+        self.assertTrue(cancelled)
         self.assertTrue(cm1.expired())
         self.assertTrue(cm2.expired())
 
     async def test_waiter_cancelled(self):
+        loop = asyncio.get_running_loop()
+        cancelled = False
         with self.assertRaises(TimeoutError):
             async with asyncio.timeout(0.01):
-                with self.assertRaises(asyncio.CancelledError):
+                try:
                     await asyncio.sleep(10)
+                except asyncio.CancelledError:
+                    cancelled = True
+                    raise
+        self.assertTrue(cancelled)
 
     async def test_timeout_not_called(self):
         loop = asyncio.get_running_loop()
