bpo-34171: Fix test_trace. (GH-8940) (GH-8951)

miss-islington · serhiy-storchaka · serhiy-storchaka · commit e3f20828f6b7 · 2018-08-28T11:41:43.000+03:00
Remove "trace.cover" left from previous test runs before testing that it is no longer created. (cherry picked from commit b44a1d4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
diff --git a/Lib/test/test_trace.py b/Lib/test/test_trace.py
@@ -385,13 +385,16 @@ def tearDown(self):
         unlink(self.coverfile)
 
     def test_cover_files_written_no_highlight(self):
+        # Test also that the cover file for the trace module is not created
+        # (issue #34171).
+        tracedir = os.path.dirname(os.path.abspath(trace.__file__))
+        tracecoverpath = os.path.join(tracedir, 'trace.cover')
+        unlink(tracecoverpath)
+
         argv = '-m trace --count'.split() + [self.codefile]
         status, stdout, stderr = assert_python_ok(*argv)
         self.assertEqual(stderr, b'')
-        tracedir = os.path.dirname(os.path.abspath(trace.__file__))
-        tracecoverpath = os.path.join(tracedir, "trace.cover")
         self.assertFalse(os.path.exists(tracecoverpath))
-
         self.assertTrue(os.path.exists(self.coverfile))
         with open(self.coverfile) as f:
             self.assertEqual(f.read(),
