closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)

miss-islington · Alexey Izbyshev · web-flow · commit d6725fcdd54c · 2018-08-25T20:03:48.000-04:00
Reported by Svace static analyzer. (cherry picked from commit b57b4ac) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
diff --git a/Objects/abstract.c b/Objects/abstract.c
@@ -1501,7 +1501,7 @@ PySequence_Check(PyObject *s)
 {
     if (PyDict_Check(s))
         return 0;
-    return s != NULL && s->ob_type->tp_as_sequence &&
+    return s->ob_type->tp_as_sequence &&
         s->ob_type->tp_as_sequence->sq_item != NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1501,7 +1501,7 @@ PySequence_Check(PyObject *s)`
`1501`	`1501`	`{`
`1502`	`1502`	`if (PyDict_Check(s))`
`1503`	`1503`	`return 0;`
`1504`		`- return s != NULL && s->ob_type->tp_as_sequence &&`
	`1504`	`+ return s->ob_type->tp_as_sequence &&`
`1505`	`1505`	`s->ob_type->tp_as_sequence->sq_item != NULL;`
`1506`	`1506`	`}`
`1507`	`1507`