closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)

miss-islington · Alexey Izbyshev · web-flow · commit d60bdf239e32 · 2018-08-25T20:14:37.000-04:00
Reported by Svace static analyzer. (cherry picked from commit b57b4ac) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
diff --git a/Objects/abstract.c b/Objects/abstract.c
@@ -1477,7 +1477,7 @@ PySequence_Check(PyObject *s)
 {
     if (PyDict_Check(s))
         return 0;
-    return s != NULL && s->ob_type->tp_as_sequence &&
+    return s->ob_type->tp_as_sequence &&
         s->ob_type->tp_as_sequence->sq_item != NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1477,7 +1477,7 @@ PySequence_Check(PyObject *s)`
`1477`	`1477`	`{`
`1478`	`1478`	`if (PyDict_Check(s))`
`1479`	`1479`	`return 0;`
`1480`		`- return s != NULL && s->ob_type->tp_as_sequence &&`
	`1480`	`+ return s->ob_type->tp_as_sequence &&`
`1481`	`1481`	`s->ob_type->tp_as_sequence->sq_item != NULL;`
`1482`	`1482`	`}`
`1483`	`1483`