closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (GH-8869)

miss-islington · Alexey Izbyshev · web-flow · commit c7f543520161 · 2018-08-24T12:13:57.000-04:00
Reported by Svace static analyzer. (cherry picked from commit 4988453) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
@@ -1290,8 +1290,11 @@ tzinfo_from_isoformat_results(int rv, int tzoffset, int tz_useconds) {
         }
 
         PyObject *delta = new_delta(0, tzoffset, tz_useconds, 1);
+        if (delta == NULL) {
+            return NULL;
+        }
         tzinfo = new_timezone(delta, NULL);
-        Py_XDECREF(delta);
+        Py_DECREF(delta);
     } else {
         tzinfo = Py_None;
         Py_INCREF(Py_None);
