Skip to content

Commit bf3a1e9

Browse files
authored
bpo-30822: regrtest: remove tzdata (#2782)
* Oops, tzdata was introduced in Python 3.6: remove it from regrtest * Remove also Lib/test/libregrtest/__init__.py file: add by mistake on a backport.
1 parent 645e503 commit bf3a1e9

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

Lib/test/libregrtest/__init__.py

Lines changed: 0 additions & 5 deletions
This file was deleted.

Lib/test/regrtest.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,7 @@
214214
#
215215
# - extralagefile (ex: test_zipfile64): really too slow to be enabled
216216
# "by default"
217-
# - tzdata: while needed to validate fully test_datetime, it makes
218-
# test_datetime too slow (15-20 min on some buildbots) and so is disabled by
219-
# default (see bpo-30822).
220-
RESOURCE_NAMES = ALL_RESOURCES + ('extralargefile', 'tzdata')
217+
RESOURCE_NAMES = ALL_RESOURCES + ('extralargefile',)
221218

222219
# When tests are run from the Python build directory, it is best practice
223220
# to keep the test files in a subfolder. This eases the cleanup of leftover

Lib/test/test_regrtest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,9 @@ def test_use(self):
204204
self.checkError([opt, 'foo'], 'invalid resource')
205205

206206
# all + a resource not part of "all"
207-
ns = regrtest._parse_args([opt, 'all,tzdata'])
207+
ns = regrtest._parse_args([opt, 'all,extralargefile'])
208208
self.assertEqual(ns.use_resources,
209-
list(regrtest.ALL_RESOURCES) + ['tzdata'])
209+
list(regrtest.ALL_RESOURCES) + ['extralargefile'])
210210

211211
# test another resource which is not part of "all"
212212
ns = regrtest._parse_args([opt, 'extralargefile'])
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,2 @@
1-
regrtest: Exclude tzdata from regrtest --all. When running the test suite
2-
using --use=all / -u all, exclude tzdata since it makes test_datetime too
3-
slow (15-20 min on some buildbots) which then times out on some buildbots.
4-
Fix also regrtest command line parser to allow passing -u extralargefile to
1+
Fix regrtest command line parser to allow passing -u extralargefile to
52
run test_zipfile64.

0 commit comments

Comments
 (0)