bpo-29643: Fix check for --enable-optimizations (GH-129)

ts826848 · methane · commit 8cea5929f528 · 2017-03-28T21:50:51.000+09:00
The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -991,6 +991,11 @@ Tools/Demos
 - Issue #28102: The zipfile module CLI now prints usage to stderr.
   Patch by Stephen J. Turnbull.
 
+Build
+-----
+
+- bpo-29643: Fix ``--enable-optimization`` didn't work.
+
 Tests
 -----
 
diff --git a/configure b/configure
@@ -6521,7 +6521,7 @@ $as_echo_n "checking for --enable-optimizations... " >&6; }
 # Check whether --enable-optimizations was given.
 if test "${enable_optimizations+set}" = set; then :
   enableval=$enable_optimizations;
-if test "$withval" != no
+if test "$enableval" != no
 then
   Py_OPT='true'
   { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
diff --git a/configure.ac b/configure.ac
@@ -1274,7 +1274,7 @@ Py_OPT='false'
 AC_MSG_CHECKING(for --enable-optimizations)
 AC_ARG_ENABLE(optimizations, AS_HELP_STRING([--enable-optimizations], [Enable expensive optimizations (PGO, etc).  Disabled by default.]),
 [
-if test "$withval" != no
+if test "$enableval" != no
 then
   Py_OPT='true'
   AC_MSG_RESULT(yes);

Original file line number	Diff line number	Diff line change
`@@ -1274,7 +1274,7 @@ Py_OPT='false'`
`1274`	`1274`	`AC_MSG_CHECKING(for --enable-optimizations)`
`1275`	`1275`	`AC_ARG_ENABLE(optimizations, AS_HELP_STRING([--enable-optimizations], [Enable expensive optimizations (PGO, etc). Disabled by default.]),`
`1276`	`1276`	`[`
`1277`		`-if test "$withval" != no`
	`1277`	`+if test "$enableval" != no`
`1278`	`1278`	`then`
`1279`	`1279`	`Py_OPT='true'`
`1280`	`1280`	`AC_MSG_RESULT(yes);`