bpo-29873: fix INCREF for possible NULL value in element_getattr() (GH-757)

zhangyangyu · web-flow · commit 827c78326aa8 · 2017-03-22T12:25:51.000+08:00
diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
@@ -1542,7 +1542,7 @@ element_getattr(ElementObject* self, char* name)
         return res;
     } else if (strcmp(name, "text") == 0) {
         res = element_get_text(self);
-        Py_INCREF(res);
+        Py_XINCREF(res);
         return res;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1542,7 +1542,7 @@ element_getattr(ElementObject* self, char* name)`
`1542`	`1542`	`return res;`
`1543`	`1543`	`} else if (strcmp(name, "text") == 0) {`
`1544`	`1544`	`res = element_get_text(self);`
`1545`		`- Py_INCREF(res);`
	`1545`	`+ Py_XINCREF(res);`
`1546`	`1546`	`return res;`
`1547`	`1547`	`}`
`1548`	`1548`