bpo-45000: Raise SyntaxError when try to delete __debug__ (GH-27947)

corona10 · web-flow · commit 551da597a099 · 2021-08-25T10:54:20.000-07:00
Automerge-Triggered-By: GH:pablogsal
diff --git a/Doc/whatsnew/3.11.rst b/Doc/whatsnew/3.11.rst
@@ -176,6 +176,8 @@ Other CPython Implementation Changes
   support :class:`typing.SupportsComplex` and :class:`typing.SupportsBytes` protocols.
   (Contributed by Mark Dickinson and Dong-hee Na in :issue:`24234`.)
 
+*  A :exc:`SyntaxError` (instead of a :exc:`NameError`) will be raised when deleting the :const:`__debug__` constant. (Contributed by Dong-hee Na in :issue:`45000`.)
+
 
 New Modules
 ===========
diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py
@@ -59,6 +59,10 @@
 Traceback (most recent call last):
 SyntaxError: cannot assign to __debug__
 
+>>> del __debug__
+Traceback (most recent call last):
+SyntaxError: cannot delete __debug__
+
 >>> f() = 1
 Traceback (most recent call last):
 SyntaxError: cannot assign to function call here. Maybe you meant '==' instead of '='?
diff --git a/Misc/NEWS.d/next/Core and Builtins/2021-08-25-23-17-32.bpo-45000.XjmyLl.rst b/Misc/NEWS.d/next/Core and Builtins/2021-08-25-23-17-32.bpo-45000.XjmyLl.rst
@@ -0,0 +1,2 @@
+A :exc:`SyntaxError` is now raised when trying to delete :const:`__debug__`.
+Patch by Dong-hee Na.
diff --git a/Python/compile.c b/Python/compile.c
@@ -2343,6 +2343,10 @@ forbidden_name(struct compiler *c, identifier name, expr_context_ty ctx)
         compiler_error(c, "cannot assign to __debug__");
         return 1;
     }
+    if (ctx == Del && _PyUnicode_EqualToASCIIString(name, "__debug__")) {
+        compiler_error(c, "cannot delete __debug__");
+        return 1;
+    }
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+A :exc:`SyntaxError` is now raised when trying to delete :const:`__debug__`.
	`2`	`+Patch by Dong-hee Na.`
Original file line number	Diff line number	Diff line change
`@@ -2343,6 +2343,10 @@ forbidden_name(struct compiler *c, identifier name, expr_context_ty ctx)`
`2343`	`2343`	`compiler_error(c, "cannot assign to __debug__");`
`2344`	`2344`	`return 1;`
`2345`	`2345`	`}`
	`2346`	`+ if (ctx == Del && _PyUnicode_EqualToASCIIString(name, "__debug__")) {`
	`2347`	`+ compiler_error(c, "cannot delete __debug__");`
	`2348`	`+ return 1;`
	`2349`	`+ }`
`2346`	`2350`	`return 0;`
`2347`	`2351`	`}`
`2348`	`2352`