Skip to content

Commit 3404ded

Browse files
miss-islingtonzoobachris-eibl
authored
[3.15] gh-153668: Temporarily disable unicodectype.c optimization on WinARM64 due to compiler bug (GH-153669) (#157842)
gh-153668: Temporarily disable unicodectype.c optimization on WinARM64 due to compiler bug (GH-153669) * Only disable during Release (not PGO) * Update PCbuild/pyproject.props --------- (cherry picked from commit 9ea05d4) Co-authored-by: Steve Dower <[email protected]> Co-authored-by: Chris Eibl <[email protected]>
1 parent 94f02ed commit 3404ded

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

‎PCbuild/pyproject.props‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
<!-- See https://developercommunity.visualstudio.com/t/Regression-in-MSVC-1433-1434-ARM64-co/10224361 -->
4141
<MSVCHasBrokenARM64Clamping Condition="$(_VCToolsVersion) == '14.34' or $(_VCToolsVersion) == '14.35'">true</MSVCHasBrokenARM64Clamping>
4242
<MSVCHasBrokenARM64SignExtension Condition="$(_VCToolsVersion) == '14.37'">true</MSVCHasBrokenARM64SignExtension>
43+
<!-- See gh-153668 and https://developercommunity.visualstudio.com/t/ARM64-compiler-uses-excessive-memory-on/11120089 -->
44+
<MSVCHasBrokenARM64UniDbOpt Condition="$(_VCToolsVersion) == '14.50' or $(_VCToolsVersion) == '14.51'">true</MSVCHasBrokenARM64UniDbOpt>
4345
</PropertyGroup>
4446

4547
<PropertyGroup>

‎PCbuild/pythoncore.vcxproj‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,10 @@
575575
<ClCompile Include="..\Objects\typeobject.c" />
576576
<ClCompile Include="..\Objects\typevarobject.c" />
577577
<ClCompile Include="..\Objects\unicode_format.c" />
578-
<ClCompile Include="..\Objects\unicodectype.c" />
578+
<ClCompile Include="..\Objects\unicodectype.c">
579+
<!-- gh-153668: Temporarily disabled due to a compiler bug -->
580+
<Optimization Condition="$(Platform) == 'ARM64' and $(Configuration) == 'Release' and $(MSVCHasBrokenARM64UniDbOpt) == 'true'">Disabled</Optimization>
581+
</ClCompile>
579582
<ClCompile Include="..\Objects\unicode_formatter.c" />
580583
<ClCompile Include="..\Objects\unicode_writer.c" />
581584
<ClCompile Include="..\Objects\unicodeobject.c" />

0 commit comments

Comments
 (0)