bpo-44422: Fix threading.enumerate() reentrant call (GH-26727)

vstinner · web-flow · commit 243fd01047dd · 2021-06-15T16:14:24.000+02:00
The threading.enumerate() function now uses a reentrant lock to
prevent a hang on reentrant call.
diff --git a/Lib/threading.py b/Lib/threading.py
@@ -775,8 +775,11 @@ class BrokenBarrierError(RuntimeError):
 def _newname(name_template):
     return name_template % _counter()
 
-# Active thread administration
-_active_limbo_lock = _allocate_lock()
+# Active thread administration.
+#
+# bpo-44422: Use a reentrant lock to allow reentrant calls to functions like
+# threading.enumerate().
+_active_limbo_lock = RLock()
 _active = {}    # maps thread id to Thread object
 _limbo = {}
 _dangling = WeakSet()
@@ -1564,7 +1567,7 @@ def _after_fork():
     # by another (non-forked) thread.  http://bugs.python.org/issue874900
     global _active_limbo_lock, _main_thread
     global _shutdown_locks_lock, _shutdown_locks
-    _active_limbo_lock = _allocate_lock()
+    _active_limbo_lock = RLock()
 
     # fork() only copied the current thread; clear references to others.
     new_active = {}
diff --git a/Misc/NEWS.d/next/Library/2021-06-14-23-28-17.bpo-44422.BlWOgv.rst b/Misc/NEWS.d/next/Library/2021-06-14-23-28-17.bpo-44422.BlWOgv.rst
@@ -0,0 +1,3 @@
+The :func:`threading.enumerate` function now uses a reentrant lock to
+prevent a hang on reentrant call.
+Patch by Victor Stinner.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+The :func:`threading.enumerate` function now uses a reentrant lock to
	`2`	`+prevent a hang on reentrant call.`
	`3`	`+Patch by Victor Stinner.`