[3.12] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (#105675)

miss-islington · sobolevn · web-flow · commit 0b305e8d36c5 · 2023-06-12T09:15:45.000Z
In sys_add_xoption(), 'value' may be uninitialized for some error paths. (cherry picked from commit a8d69fe) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -3371,7 +3371,7 @@ _PySys_InitCore(PyThreadState *tstate, PyObject *sysdict)
 static int
 sys_add_xoption(PyObject *opts, const wchar_t *s)
 {
-    PyObject *name, *value;
+    PyObject *name, *value = NULL;
 
     const wchar_t *name_end = wcschr(s, L'=');
     if (!name_end) {

Original file line number	Diff line number	Diff line change
`@@ -3371,7 +3371,7 @@ _PySys_InitCore(PyThreadState tstate, PyObject sysdict)`
`3371`	`3371`	`static int`
`3372`	`3372`	`sys_add_xoption(PyObject opts, const wchar_t s)`
`3373`	`3373`	`{`
`3374`		`- PyObject name, value;`
	`3374`	`+ PyObject name, value = NULL;`
`3375`	`3375`
`3376`	`3376`	`const wchar_t *name_end = wcschr(s, L'=');`
`3377`	`3377`	`if (!name_end) {`