Improve error message for "setup.py upload" without dist files (#21060)

merwok · web-flow · commit 08a6926b2584 · 2018-02-18T18:14:54.000-05:00
diff --git a/Lib/distutils/command/upload.py b/Lib/distutils/command/upload.py
@@ -57,7 +57,8 @@ def finalize_options(self):
 
     def run(self):
         if not self.distribution.dist_files:
-            msg = "No dist file created in earlier command"
+            msg = ("Must create and upload files in one command "
+                   "(e.g. setup.py sdist upload)")
             raise DistutilsOptionError(msg)
         for command, pyversion, filename in self.distribution.dist_files:
             self.upload_file(command, pyversion, filename)
diff --git a/Misc/NEWS.d/next/Library/2018-02-17-19-20-19.bpo-21060.S1Z-x6.rst b/Misc/NEWS.d/next/Library/2018-02-17-19-20-19.bpo-21060.S1Z-x6.rst
@@ -0,0 +1,3 @@
+Rewrite confusing message from setup.py upload from
+"No dist file created in earlier command" to the more helpful
+"Must create and upload files in one command".

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Rewrite confusing message from setup.py upload from`
	`2`	`+"No dist file created in earlier command" to the more helpful`
	`3`	`+"Must create and upload files in one command".`