Skip to content

Update fields for triage membership template #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 2 commits into from
Jan 23, 2023
Merged

Update fields for triage membership template #491

hugovk merged 2 commits into from
Jan 23, 2023

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Jan 23, 2023

Remove "bpo username" from the table: even if new triagers have BPO usernames, I don't think we need this information any more.

Add "Request for Python triage membership: name" as a title for the template, so it's prefilled when creating a new request issue.

@hugovk hugovk added the project: triagers Adding triagers project label Jan 23, 2023
@CAM-Gerlach CAM-Gerlach mentioned this pull request Jan 23, 2023
Merged
CAM-Gerlach
CAM-Gerlach approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk — FYI, as this branch was created on upstream instead of your fork (presumably due to a mistake), #460 is now blocked on merging, moving or deleting this (which would prevent such by accident in the future).

Also, TIL you can add a default title—will definitely use that on python/peps#2956 (assuming it works for PRs...I honestly have no idea if anyone of it will actually work at all yet).

This was referenced Jan 23, 2023
Closed
Merged
@hugovk
Copy link
Member Author

hugovk commented Jan 23, 2023

LGTM, thanks @hugovk — FYI, as this branch was created on upstream instead of your fork (presumably due to a mistake), #460 is now blocked on merging, moving or deleting this (which would prevent such by accident in the future).

Not a mistake, intentionally created via GitHub's UI for a (hopefully) quick merge :)

If this doesn't get merged in ~24h I can close and re-open on my fork, or if it's imminently blocking #460 please close this and I'll re-open later.

Also, TIL you can add a default title—will definitely use that on python/peps#2956 (assuming it works for PRs...I honestly have no idea if anyone of it will actually work at all yet).

👍 + 🤞

JelleZijlstra
JelleZijlstra reviewed Jan 23, 2023
View reviewed changes
@hugovk hugovk merged commit 8eb8d10 into master Jan 23, 2023
@hugovk hugovk deleted the update-triage-request-template branch January 23, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

project: triagers Adding triagers project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hugovk @JelleZijlstra @CAM-Gerlach @ezio-melotti @AlexWaygood