Skip to content

Disable network tests on pablogsal-arch-x86_64#684

Merged
vstinner merged 3 commits intopython:mainfrom
vstinner:network
Mar 18, 2026
Merged

Disable network tests on pablogsal-arch-x86_64#684
vstinner merged 3 commits intopython:mainfrom
vstinner:network

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Mar 16, 2026

No description provided.

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 16, 2026

Example of recent failure on "AMD64 Arch Linux Usan Function 3.13": https://buildbot.python.org/#/builders/1601/builds/687

test_ftp_timeout (test.test_urllib2net.TimeoutTest.test_ftp_timeout) ... Timeout (0:20:00)!
Thread 0x000074b731261100 (most recent call first):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/socket.py", line 849 in create_connection
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/ftplib.py", line 354 in ntransfercmd
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/urllib/request.py", line 2469 in retrfile
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/urllib/request.py", line 1549 in ftp_open
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/urllib/request.py", line 466 in _call_chain
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/urllib/request.py", line 506 in _open
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/urllib/request.py", line 489 in open
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/urllib/request.py", line 189 in urlopen
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/test/test_urllib2net.py", line 25 in _retry_thrice
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/test/test_urllib2net.py", line 33 in wrapped
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.clang-ubsan-function/build/Lib/test/test_urllib2net.py", line 412 in test_ftp_timeout
  ...
1 test failed again:
    test_urllib2net

This was referenced Mar 16, 2026
Open
Merged
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 16, 2026

cc @StanFromIreland @pablogsal

StanFromIreland
StanFromIreland reviewed Mar 16, 2026
View reviewed changes
Comment thread master/custom/workers.py
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 16, 2026

[pablogsal-macos-m1] I think we should include it too? IIRC it also has similar failures.

I saw it but I didn't know if it's connected to the same ISP. I checked for test_urllib2net failures and I found a few on this worker:

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 16, 2026

I updated the PR to skip also network tests on pablogsal-macos-m1.

StanFromIreland
StanFromIreland reviewed Mar 17, 2026
View reviewed changes
Comment thread master/custom/workers.py
parallel_tests=4,
# Tests fail with latin1 encoding on 3.12, probably earlier
not_branches=['3.12', '3.11', '3.10'],
# Problematic ISP causes issues connecting to testpython.net
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one comment, although I don't really think we need to change it, but I also don't object.

Copy link
Copy Markdown
Member Author

@vstinner vstinner Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind and chose to refer to testpython.net instead in the comment.

@vstinner vstinner merged commit 873b666 into python:main Mar 18, 2026
1 check passed
@vstinner vstinner deleted the network branch March 18, 2026 13:07
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 18, 2026

Merged. Thanks for reviews @StanFromIreland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @StanFromIreland