Skip to content

Comments

Avoid unnecessary rinfo calls after creating gateways#909

Merged
nicoddemus merged 3 commits intopytest-dev:masterfrom
nicoddemus:avoid-rinfo
May 19, 2023
Merged

Avoid unnecessary rinfo calls after creating gateways#909
nicoddemus merged 3 commits intopytest-dev:masterfrom
nicoddemus:avoid-rinfo

Conversation

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented May 18, 2023

Hopefully this fixes #907, as seems this is the only change in #901 which is somehow related.

@nicoddemus nicoddemus mentioned this pull request May 18, 2023
Closed
Avoid unnecessary rinfo calls after creating gateways
29885b0 
Hopefully this fixes pytest-dev#907, as seems this is the only
change in pytest-dev#901 which is somehow related.
@CaselIT
Copy link

CaselIT commented May 18, 2023

I'll try to run sqlalchemy test on this branch later

@nicoddemus
Copy link
Member Author

nicoddemus commented May 18, 2023

@CaselIT oh that would be great, thanks!

CaselIT added a commit to sqlalchemy/sqlalchemy that referenced this pull request May 18, 2023
@CaselIT
try pytest-xdist patch pytest-dev/pytest-xdist#909
a77a3ea 
Change-Id: I4bc459895692931db30b9e5b98d10d94f1cdc5ac
@CaselIT
Copy link

CaselIT commented May 18, 2023 •
edited
Loading

This run should use the patch you added https://github.com/sqlalchemy/sqlalchemy/actions/runs/5018530060

It will take a while since there are other 3 pipeline in the queue before it

CaselIT added a commit to sqlalchemy/sqlalchemy that referenced this pull request May 18, 2023
@CaselIT
try pytest-xdist patch pytest-dev/pytest-xdist#909
d5beb16 
Change-Id: I4bc459895692931db30b9e5b98d10d94f1cdc5ac
CaselIT added a commit to sqlalchemy/sqlalchemy that referenced this pull request May 18, 2023
@CaselIT
try pytest-xdist patch pytest-dev/pytest-xdist#909
eb0622e 
Change-Id: I4bc459895692931db30b9e5b98d10d94f1cdc5ac
@CaselIT
Copy link

CaselIT commented May 18, 2023

Edited the link above since fumbled the tox config

@nicoddemus
Copy link
Member Author

nicoddemus commented May 19, 2023 •
edited
Loading

Thanks @CaselIT.

It passed! Can you trigger a new run to make sure it was not a fluke?

RonnyPfannschmidt
RonnyPfannschmidt reviewed May 19, 2023
View reviewed changes
@CaselIT
Copy link

CaselIT commented May 19, 2023

Thanks @CaselIT.

It passed! Can you trigger a new run to make sure it was not a fluke?

Done https://github.com/sqlalchemy/sqlalchemy/actions/runs/5018530060

RonnyPfannschmidt
RonnyPfannschmidt approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i made a rough proposal for a more informative changelog
i think its important people get a basic gist of the underlying issue

@CaselIT
Copy link

CaselIT commented May 19, 2023

Re-run also passed. trying a 3rd time just to be sure (3.3.0 failed each time in 4 runs it did, so we should be good)

@nicoddemus nicoddemus merged commit 4e7bd02 into pytest-dev:master May 19, 2023
@nicoddemus nicoddemus deleted the avoid-rinfo branch May 19, 2023 10:43
@CaselIT
Copy link

CaselIT commented May 19, 2023

also 3rd re-run seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

getting failures on slower machines since 3.3.0 release

3 participants

@nicoddemus @CaselIT @RonnyPfannschmidt