Make collection progress output less verbose#901
Merged
nicoddemus merged 2 commits intopytest-dev:masterfrom May 12, 2023
Merged
Make collection progress output less verbose#901nicoddemus merged 2 commits intopytest-dev:masterfrom
nicoddemus merged 2 commits intopytest-dev:masterfrom
Conversation
nicoddemus
force-pushed
the
555-improved-col-progress
branch
2 times, most recently
from
0839436 to
6cc3a39
Compare
nicoddemus
force-pushed
the
555-improved-col-progress
branch
from
6cc3a39 to
d292e82
Compare
bluetech
approved these changes
May 10, 2023
| statuses = [s for s, c in status_and_items] | ||
| total_workers = len(statuses) | ||
| workers_noun = "worker" if total_workers == 1 else "workers" | ||
| if status_and_items and all(s == WorkerStatus.CollectionDone for s in statuses): |
Member
There was a problem hiding this comment.
is not status_and_items possible?
Member
Author
There was a problem hiding this comment.
In the current design not really, but given the type cannot prevent that, I thought better guard against that, because all([]) returns True and will break on the next line -- the first parametrization of test_get_workers_status_line checks that.
RonnyPfannschmidt
approved these changes
May 12, 2023
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
This is a little gnarly, but the ux is no longer 🎊
nicoddemus
pushed a commit
to nicoddemus/pytest-xdist
that referenced
this pull request
May 18, 2023
Hopefully this fixes pytest-dev#907, as seems this is the only change in pytest-dev#901 which is somehow related.
nicoddemus
pushed a commit
to nicoddemus/pytest-xdist
that referenced
this pull request
May 18, 2023
Hopefully this fixes pytest-dev#907, as seems this is the only change in pytest-dev#901 which is somehow related.
nicoddemus
added a commit
that referenced
this pull request
May 19, 2023
Hopefully this fixes #907, as seems this is the only change in #901 which is somehow related. --------- Co-authored-by: Ronny Pfannschmidt <[email protected]>
Member
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #555