Fix hang caused by steal command with empty test queue#885
Merged
amezin merged 1 commit intopytest-dev:masterfrom Mar 10, 2023
Merged
Fix hang caused by steal command with empty test queue#885amezin merged 1 commit intopytest-dev:masterfrom
steal command with empty test queue#885amezin merged 1 commit intopytest-dev:masterfrom
Conversation
nicoddemus
approved these changes
Mar 9, 2023
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Left a few minor suggestions, otherwise LGTM. 👍
Thanks for tackling this so quickly.
After this gets merged, feel free to prepare a new release.
|
Verified this stops the hanging we were seeing in the |
nicoddemus
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #884