Conversation
nirs
reviewed
Oct 5, 2019
nirs
left a comment
nirs
left a comment
There was a problem hiding this comment.
Looks good, and fixes vdsm tests:
platform linux2 -- Python 2.7.16, pytest-4.0.0, py-1.8.0, pluggy-0.13.0
cachedir: .tox/network-py27/.pytest_cache
rootdir: /home/nsoffer/src/vdsm, inifile: tox.ini
plugins: cov-2.8.1
collected 151 items
...
---------- coverage: platform linux2, python 2.7.16-final-0 ----------
Coverage HTML written to dir htmlcov-network-py27
FAIL Required test coverage of 42% not reached. Total coverage: 36.28%
(Lot of tests require root, coverage failure is expected for this run)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #348 .