Thanks. But the tests still fail on Python 3.

And please add the following test cases for the new feature:

• working case (total > cov_min)
• error case (total < cov_min)
• no output configured (--cov-report=): this probably crashes right now. Printing a summary to os.devnull to get the total should be working in this case.

Do you have a working test suite? Simply running tox doesn't appear to be doing much ;)

You need to run tox in pytest-cov subdirectory :)

I just updated the 2.0 branch, please rebase your changes.

The no output case isn't a problem in terms of stability since that just returns the default of 0% coverage right now. Besides that, it defaults to term in your code ;)

I've added the tests in any case.

Your test case is not testing disabled output. You need to pass --cov-report= explicitly without an parameter. In this case summary returns None (https://github.com/WoLpH/pytest-cov/blob/2.0/cov-core/cov_core.py#L82) which should crash, at least on Python 3.

Plus, returning 0 in the no output case is not the right behavior. total should still be correctly calculated.

Ah, I thought that wasn't an option here. Guess I was tricked by this line: https://github.com/schlamar/pytest-cov/blob/master/pytest_cov.py#L95
self.options.cov_report or ['term'],

If the pytest-cov plugin would have been enabled I wouldn't have missed this of course ;)

Great. Thank you 🍰