Remove the backup context manager - shouldn't be needed since coverage 5.0, see https://coverage.readthedocs.io/en/latest/changes.html#version-5-0a7-2019-09-21

ionelmc · ionelmc · commit 861d30e60d57 · 2026-03-21T19:50:16.000+02:00
diff --git a/src/pytest_cov/engine.py b/src/pytest_cov/engine.py
@@ -2,7 +2,6 @@
 
 import argparse
 import contextlib
-import copy
 import functools
 import os
 import random
@@ -31,16 +30,6 @@ def write(v):
         pass
 
 
-@contextlib.contextmanager
-def _backup(obj, attr):
-    backup = getattr(obj, attr)
-    try:
-        setattr(obj, attr, copy.copy(backup))
-        yield
-    finally:
-        setattr(obj, attr, backup)
-
-
 def _ensure_topdir(meth):
     @functools.wraps(meth)
     def ensure_topdir_wrapper(self, *args, **kwargs):
@@ -151,8 +140,7 @@ def sep(self, stream, s, txt):
     def summary(self, stream):
         """Produce coverage reports."""
 
-        with _backup(self.cov, 'config'):
-            total = self.cov.report(ignore_errors=True, output_format='total', precision=self.cov_precision, file=_NullFile)
+        total = self.cov.report(ignore_errors=True, output_format='total', precision=self.cov_precision, file=_NullFile)
 
         # Output coverage section header.
         if len(self.node_descs) == 1:
@@ -179,20 +167,17 @@ def summary(self, stream):
             }
             skip_covered = isinstance(self.cov_report, dict) and 'skip-covered' in self.cov_report.values()
             options.update({'skip_covered': skip_covered or None})
-            with _backup(self.cov, 'config'):
-                self.cov.report(**options)
+            self.cov.report(**options)
 
         # Produce annotated source code report if wanted.
         if 'annotate' in self.cov_report:
             annotate_dir = self.cov_report['annotate']
 
-            with _backup(self.cov, 'config'):
-                self.cov.annotate(ignore_errors=True, directory=annotate_dir)
+            self.cov.annotate(ignore_errors=True, directory=annotate_dir)
             # We need to call Coverage.report here, just to get the total
             # Coverage.annotate don't return any total and we need it for --cov-fail-under.
 
-            with _backup(self.cov, 'config'):
-                self.cov.report(ignore_errors=True, file=_NullFile)
+            self.cov.report(ignore_errors=True, file=_NullFile)
             if annotate_dir:
                 stream.write(f'Coverage annotated source written to dir {annotate_dir}\n')
             else:
@@ -201,49 +186,43 @@ def summary(self, stream):
         # Produce html report if wanted.
         if 'html' in self.cov_report:
             output = self.cov_report['html']
-            with _backup(self.cov, 'config'):
-                self.cov.html_report(ignore_errors=True, directory=output)
+            self.cov.html_report(ignore_errors=True, directory=output)
             stream.write(f'Coverage HTML written to dir {self.cov.config.html_dir if output is None else output}\n')
 
         # Produce xml report if wanted.
         if 'xml' in self.cov_report:
             output = self.cov_report['xml']
-            with _backup(self.cov, 'config'):
-                self.cov.xml_report(ignore_errors=True, outfile=output)
+            self.cov.xml_report(ignore_errors=True, outfile=output)
             stream.write(f'Coverage XML written to file {self.cov.config.xml_output if output is None else output}\n')
 
         # Produce json report if wanted
         if 'json' in self.cov_report:
             output = self.cov_report['json']
-            with _backup(self.cov, 'config'):
-                self.cov.json_report(ignore_errors=True, outfile=output)
+            self.cov.json_report(ignore_errors=True, outfile=output)
             stream.write('Coverage JSON written to file %s\n' % (self.cov.config.json_output if output is None else output))
 
         # Produce Markdown report if wanted.
         if 'markdown' in self.cov_report:
             output = self.cov_report['markdown']
-            with _backup(self.cov, 'config'):
-                with Path(output).open('w') as output_file:
-                    self.cov.report(ignore_errors=True, file=output_file, output_format='markdown')
+            with Path(output).open('w') as output_file:
+                self.cov.report(ignore_errors=True, file=output_file, output_format='markdown')
             stream.write(f'Coverage Markdown information written to file {output}\n')
 
         # Produce Markdown report if wanted, appending to output file
         if 'markdown-append' in self.cov_report:
             output = self.cov_report['markdown-append']
-            with _backup(self.cov, 'config'):
-                with Path(output).open('a') as output_file:
-                    self.cov.report(ignore_errors=True, file=output_file, output_format='markdown')
+            with Path(output).open('a') as output_file:
+                self.cov.report(ignore_errors=True, file=output_file, output_format='markdown')
             stream.write(f'Coverage Markdown information appended to file {output}\n')
 
         # Produce lcov report if wanted.
         if 'lcov' in self.cov_report:
             output = self.cov_report['lcov']
-            with _backup(self.cov, 'config'):
-                self.cov.lcov_report(ignore_errors=True, outfile=output)
+            self.cov.lcov_report(ignore_errors=True, outfile=output)
 
-                # We need to call Coverage.report here, just to get the total
-                # Coverage.lcov_report doesn't return any total and we need it for --cov-fail-under.
-                self.cov.report(ignore_errors=True, file=_NullFile)
+            # We need to call Coverage.report here, just to get the total
+            # Coverage.lcov_report doesn't return any total and we need it for --cov-fail-under.
+            self.cov.report(ignore_errors=True, file=_NullFile)
 
             stream.write(f'Coverage LCOV written to file {self.cov.config.lcov_output if output is None else output}\n')
 
