Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 3 3
Lines 275 275
Branches 41 41
=======================================
Hits 256 256
Misses 12 12
Partials 7 7 Continue to review full report at Codecov.
|
setup.py is no longer necessary when the project is installed with a PEP 517 compatible build. Pip has support for PEP 517 since v19.0. The setuptools documentation warns about removing setup.py when editable installations need to be possible. This shouldn't be an issue since editable installations are still possible with pip v21.1 or newer. [1] I don't think a bump of the minimal setuptools version is necessary for this change. Closes pytest-dev#283 [1] https://pip.pypa.io/en/stable/news/#v21-1 Signed-off-by: Michael Seifert <[email protected]>
Signed-off-by: Michael Seifert <[email protected]>
seifertm
force-pushed
the
remove-setup.py
branch
from
d86da0e to
e223755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py is no longer necessary when the project is installed with a PEP 517 compatible build. Pip has support for PEP 517 since v19.0.
The setuptools documentation warns about removing setup.py when editable installations need to be possible. This shouldn't be an issue since editable installations are still possible with pip v21.1 or newer. [1]
I don't think a bump of the minimal setuptools version is necessary for this change.
Closes #283
[1] https://pip.pypa.io/en/stable/news/#v21-1