Conversation
Tinche
requested changes
Jan 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 93.13% 93.02% -0.11%
==========================================
Files 3 3
Lines 233 258 +25
Branches 33 33
==========================================
+ Hits 217 240 +23
- Misses 10 12 +2
Partials 6 6
Continue to review full report at Codecov.
|
Contributor
Author
|
The PR is green |
Contributor
Author
|
Merged, if we require the type info -- better to add it fast, other PRs can use typing from the very beginning. |
asvetlov
added a commit
that referenced
this pull request
Jan 15, 2022
|
That's great thank you very much. Sorry for the lack of response to your question in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type checking is rough, better checks require not released yet pytest 7.0 at least.
Tests are not typed to don't pollute this big enough PR.
They can be typed later.
Fixes #198