main: fix only one doctest collected on pytest --doctest-modules __init__.py#8022
Merged
bluetech merged 1 commit intopytest-dev:masterfrom Nov 13, 2020
Merged
main: fix only one doctest collected on pytest --doctest-modules __init__.py#8022bluetech merged 1 commit intopytest-dev:masterfrom
bluetech merged 1 commit intopytest-dev:masterfrom
Conversation
…it__.py When --doctest-modules is used, an `__init__.py` file is not a `Package` but a `DoctestModule`, but some collection code assumed that `__init__.py` implies a `Package`. That code caused only a single test to be collected in the scenario in the subject. Tighten up this check to explicitly check for `Package`. There are better solutions, but for another time. Report & test by Nick Gates <[email protected]>.
nicoddemus
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8016. Closes #8015.
When
--doctest-modulesis used, an__init__.pyfile is not aPackagebut aDoctestModule, but some collection code assumed that__init__.pyimplies aPackage. That code caused only a single test to be collected in the scenario in the subject.Tighten up this check to explicitly check for
Package. There are better solutions, but for another time.Report & test by @gatesn.