Skip link checks when doing releases through the bot#6916
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Mar 13, 2020
Merged
Skip link checks when doing releases through the bot#6916nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus merged 1 commit intopytest-dev:masterfrom
Conversation
Unfortunately this is really getting in the way of the releases not because of broken links, but because it is very flaky. Related: pytest-dev#6894
RonnyPfannschmidt
approved these changes
Mar 13, 2020
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
as a follow-up we might want to consider schedule based link-checks +
Member
Author
The idea is good, but I'm not sure if the scheduled based job won't just be ignored in the end. |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Mar 13, 2020
Skip link checks when doing releases through the bot
nicoddemus
added a commit
that referenced
this pull request
Mar 13, 2020
[Backport] Skip link checks when doing releases through the bot (#6916)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this is really getting in the way of the releases not because
of broken links, but because it is very flaky.
Related: #6894