Revert "A warning is now issued when assertions are made for None"#6234
Revert "A warning is now issued when assertions are made for None"#6234asottile merged 1 commit intopytest-dev:masterfrom asottile:remove_none_warning
None"#6234Conversation
There was a problem hiding this comment.
I think it is a good feature in general, and should therefore get fixed / improved instead.
If being reverted there should be a test for the new behavior then at least.
But I think we should decide what to do in #4639 first.
| def test_tuple_warning(self, testdir): | ||
| testdir.makepyfile( | ||
| """ | ||
| """\ |
There was a problem hiding this comment.
Please do not change code unnecessary, especially when it is only to please your editor in some way (IIRC).
For all others this adds visual disbalance, and often gets highlighted in a special way (line continuation).
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
I think this is good to go as is, don't see why we would need a test for it. 👍
|
This can go to |
|
rebased on master! |
|
Oof another one bites the dust then (honestly it’s pretty satisfying seeing the revert being this smooth). Is it worth it to try and eliminate the false positive? Maybe try and only warn if it fails the test? (Some kinda |
|
@Tadaboody I don't think so, most cases the test will at least fail with a message anyway, as @asottile pointed out. @blueyed anything else here? |
I do not like the (unnecessary) code style change (and being ignored for pointing it out (across a rebase where it could have been fixed)), and will likely investigate in what I've said in #4639 (comment). |
4 participants
Resolves #4639
CC @Tadaboody