Node from parent by RonnyPfannschmidt · Pull Request #5975 · pytest-dev/pytest

RonnyPfannschmidt · 2019-10-16T19:53:47Z

this pr experiments with introducing a Node.from_parent api that is to replace the smart constructors eventually

it will take a while manifest this experiment

RonnyPfannschmidt · 2019-10-28T06:04:59Z

this is now in a shape where critical examination is needed and merge after history clean/detail fixes

RonnyPfannschmidt · 2019-10-28T06:06:05Z

scrap that, i realized that i want to ensure the arguments are severely limited in order to prepare the switchover

blueyed · 2019-10-28T11:53:10Z

+    @classmethod
+    def from_parent(cls, parent, **kw):
+        return cls._create(**kw, parent=parent)
+


What's the benefit compared to making parent a required argument in general? (would avoid a lot of changes at least)

i need to establish a distinct construction pattern in order to then follow up with cleaning up the node construction (thats overly smart and auto-creating different things)

i tried a few times before without that and just failed flat on those occasions

Ok.
But maybe then we could just revert it to "normal" object instantiation afterwards? (i.e. before merging, not requiring all the warnings etc).

I think raising TypeErrors and using type annotations in general could be enough?

as soon as the ctor situation is largely resolved and the pattern is established, the meta class can go

nicoddemus

Overall this looks great!

Other than that, please also add an entry to deprecations.rst with a .. deprecated:: directive, and more importantly, a longer rationale of the reasons why this is being deprecated.

RonnyPfannschmidt · 2019-11-08T17:38:57Z

i believe im done with the technical part now, will take a look at doing docs over the weekend

This reverts commit a3c8246, reversing changes made to 886b8d2. Ref: pytest-dev#5975 (comment) Conflicts: src/_pytest/main.py src/_pytest/unittest.py Squashed: 7c4b8a0 Revert "Node from parent (pytest-dev#5975)" 89abdb9 keep test, warning c9062ed warn via NodeMeta 149bddb keep/adjust testing/test_mark.py:1013::test_addmarker_order de91222 tests: handle DefinitionMock 9e3b17f fix testing/test_collection.py:453::TestSession::test_parsearg Conflicts: both modified: src/_pytest/nodes.py both modified: src/_pytest/python.py

The Node API was changed in pytest 5.4 in pytest-dev/pytest#5975. This commit adds support for the new API but maintains backwards compatiblity. Closes: #11

Keeps `Node.from_parent` for backward compatibility. This reverts commit a3c8246, reversing changes made to 886b8d2. Ref: pytest-dev#5975 (comment)

RonnyPfannschmidt changed the base branch from master to features October 16, 2019 19:53

nicoddemus reviewed Oct 22, 2019

View reviewed changes

Comment thread src/_pytest/python.py Resolved

RonnyPfannschmidt mentioned this pull request Oct 27, 2019

deprecation exceptions not displayed in pytester #6083

Closed

bluetech reviewed Oct 27, 2019

View reviewed changes

Comment thread src/_pytest/nodes.py Resolved

RonnyPfannschmidt force-pushed the node-from-parent branch from dd515e0 to fe251f4 Compare October 28, 2019 06:03

RonnyPfannschmidt changed the title ~~[WIP] [POC] Node from parent~~ [POC] Node from parent Oct 28, 2019

RonnyPfannschmidt mentioned this pull request Oct 28, 2019

[bug] pytest_collect_file gets called multiple times #6088

Closed

RonnyPfannschmidt changed the title ~~[POC] Node from parent~~ [WIP][POC] Node from parent Oct 28, 2019

blueyed reviewed Oct 28, 2019

View reviewed changes

bluetech reviewed Oct 28, 2019

View reviewed changes

Comment thread src/_pytest/nodes.py Resolved

RonnyPfannschmidt force-pushed the node-from-parent branch from 1dd2483 to 20c2424 Compare October 28, 2019 20:30

bluetech reviewed Oct 29, 2019

View reviewed changes

Comment thread src/_pytest/nodes.py Resolved

RonnyPfannschmidt force-pushed the node-from-parent branch from 20c2424 to 5217483 Compare October 29, 2019 08:30

blueyed reviewed Nov 5, 2019

View reviewed changes

Comment thread src/_pytest/unittest.py Resolved

nicoddemus requested changes Nov 7, 2019

View reviewed changes

Comment thread src/_pytest/nodes.py Resolved

Comment thread changelog/5975.deprecation.rst Resolved

Comment thread testing/test_mark.py Resolved

Comment thread testing/test_nodes.py Resolved

blueyed reviewed Nov 9, 2019

View reviewed changes

Comment thread changelog/5975.deprecation.rst Resolved

RonnyPfannschmidt mentioned this pull request Nov 10, 2019

A bit more typing around Node #6167

Merged

RonnyPfannschmidt force-pushed the node-from-parent branch 2 times, most recently from 88a0e82 to 43b5c30 Compare November 22, 2019 23:07

RonnyPfannschmidt changed the title ~~[WIP][POC] Node from parent~~ Node from parent [DONT MERGE; BUT CHECK] Nov 23, 2019

nicoddemus approved these changes Nov 23, 2019

View reviewed changes

RonnyPfannschmidt force-pushed the node-from-parent branch from 894b187 to 0a7b948 Compare November 23, 2019 19:20

RonnyPfannschmidt changed the title ~~Node from parent [DONT MERGE; BUT CHECK]~~ Node from parent Nov 23, 2019

RonnyPfannschmidt and others added 2 commits November 23, 2019 21:54

deprecate direct node construction and introduce Node.from_parent

c99c7d0

update doc examples **untested**

15ffe63

RonnyPfannschmidt force-pushed the node-from-parent branch from 0a7b948 to 15ffe63 Compare November 23, 2019 20:54

nicoddemus merged commit a3c8246 into pytest-dev:features Nov 23, 2019

blueyed mentioned this pull request Jan 31, 2020

Remove Node.from_parent/.from_config indirection #6645

Closed

3 tasks

mjpieters mentioned this pull request Mar 12, 2020

pytest 5.4.0 deprecated pytest.Function() construction pytest-dev/pytest-asyncio#141

Closed

pllim mentioned this pull request Mar 13, 2020

MNT: Compat with pytest 5.4.0 scientific-python/pytest-doctestplus#95

Closed

twmr added a commit to twmr/pytest-sphinx that referenced this pull request Apr 1, 2020

Adapt to Node API change

b391be6

The Node API was changed in pytest 5.4 in pytest-dev/pytest#5975. This commit adds support for the new API but maintains backwards compatiblity. Closes: #11

twmr mentioned this pull request Apr 1, 2020

Adapt to Node API change twmr/pytest-sphinx#12

Merged

twmr added a commit to twmr/pytest-sphinx that referenced this pull request Apr 1, 2020

Adapt to Node API change

8d38df8

The Node API was changed in pytest 5.4 in pytest-dev/pytest#5975. This commit adds support for the new API but maintains backwards compatiblity. Closes: #11

twmr added a commit to twmr/pytest-sphinx that referenced this pull request Apr 1, 2020

Adapt to Node API change

f9decc0

The Node API was changed in pytest 5.4 in pytest-dev/pytest#5975. This commit adds support for the new API but maintains backwards compatiblity. Closes: #11

twmr added a commit to twmr/pytest-sphinx that referenced this pull request Apr 1, 2020

Adapt to Node API change

5123745

The Node API was changed in pytest 5.4 in pytest-dev/pytest#5975. This commit adds support for the new API but maintains backwards compatiblity. Closes: #11

sallner mentioned this pull request Apr 2, 2020

Avoid DeprecationWarnings issued from 5.4.0 on. zopefoundation/zope.pytestlayer#8

Closed

karenfeng mentioned this pull request Aug 20, 2020

Update sybil dependency projectglow/glow#284

Merged

2 of 3 tasks

blueyed mentioned this pull request Sep 1, 2020

WIP: Revert "Node from parent (pytest-dev/pytest#5975)" (take 2) blueyed/pytest#421

Open

1 task

blueyed added a commit to blueyed/pytest that referenced this pull request Sep 2, 2020

fixup! WIP: Revert "Node from parent (pytest-dev#5975)"

00454d0

blueyed added a commit to blueyed/pytest that referenced this pull request Sep 2, 2020

fixup! fixup! WIP: Revert "Node from parent (pytest-dev#5975)"

4a8833f

blueyed added a commit to blueyed/pytest that referenced this pull request Sep 16, 2020

fixup! WIP: Revert "Node from parent (pytest-dev#5975)"

1fe239f

blueyed added a commit to blueyed/pytest that referenced this pull request Sep 16, 2020

fixup! fixup! WIP: Revert "Node from parent (pytest-dev#5975)"

b7002be

blueyed added a commit to blueyed/pytest that referenced this pull request Nov 5, 2020

fixup! WIP: Revert "Node from parent (pytest-dev#5975)"

dfa465f

bors Bot referenced this pull request in aragilar/spaceplot Apr 17, 2021

Navigation Menu

Repository navigation

Node from parent - #5975

Node from parent#5975
nicoddemus merged 2 commits into
pytest-dev:featuresfrom
RonnyPfannschmidt:node-from-parent

RonnyPfannschmidt commented Oct 16, 2019

Uh oh!

Uh oh!

Uh oh!

RonnyPfannschmidt commented Oct 28, 2019

Uh oh!

RonnyPfannschmidt commented Oct 28, 2019

Uh oh!

blueyed Oct 28, 2019

Uh oh!

RonnyPfannschmidt Oct 28, 2019

Uh oh!

blueyed Nov 9, 2019

Uh oh!

RonnyPfannschmidt Nov 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicoddemus left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RonnyPfannschmidt commented Nov 8, 2019

Uh oh!

Uh oh!

Conversation

RonnyPfannschmidt commented Oct 16, 2019

Uh oh!

Uh oh!

Uh oh!

RonnyPfannschmidt commented Oct 28, 2019

Uh oh!

RonnyPfannschmidt commented Oct 28, 2019

Uh oh!

blueyed Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

RonnyPfannschmidt Oct 28, 2019

Choose a reason for hiding this comment

Uh oh!

blueyed Nov 9, 2019

Choose a reason for hiding this comment

Uh oh!

RonnyPfannschmidt Nov 23, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RonnyPfannschmidt commented Nov 8, 2019

Uh oh!

Uh oh!