Fix/Remove broken links#5613
Merged
nicoddemus merged 11 commits intopytest-dev:masterfrom Jul 17, 2019
Merged
Conversation
Although it's available, linkchecker complained about it. It was changed to the permanent redirect.
Codecov Report
@@ Coverage Diff @@
## master #5613 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 117 117
Lines 25770 25770
Branches 2495 2495
=======================================
Hits 24769 24769
Misses 696 696
Partials 305 305Continue to review full report at Codecov.
|
bluetech
reviewed
Jul 16, 2019
| Thanks `@sirex`_ for the report and `@nicoddemus`_ for the PR. | ||
|
|
||
| * Replace ``raise StopIteration`` usages in the code by simple ``returns`` to finish generators, in accordance to `PEP-479`_ (`#2160`_). | ||
| Thanks `@tgoodlet`_ for the report and `@nicoddemus`_ for the PR. |
Member
There was a problem hiding this comment.
Perhaps leave the name, just not linkified?
Everything else looks good to me!
There was a problem hiding this comment.
Yeah feel free to link to my new account if you'd like.
This was referenced Jul 16, 2019
Closed
nicoddemus
approved these changes
Jul 17, 2019
asottile
reviewed
Jul 19, 2019
| .. _@philpep: https://github.com/philpep | ||
| .. _@raquel-ucl: https://github.com/raquel-ucl | ||
| .. _@axil: https://github.com/axil | ||
| .. _@tgoodlet: https://github.com/tgoodlet |
There was a problem hiding this comment.
Heh, yeah sorry about any confusion on that one.
I finally got the username I always wanted a few months back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1722 reported broken links in CHANGELOG.
This PR fixes or removes many broken links.
This is prerequisite for a follow-up PR which adds linkcheck