tests: make test_crash_on_closing_tmpfile_py27 more reliable#4878
Merged
blueyed merged 1 commit intopytest-dev:masterfrom Mar 4, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4878 +/- ##
==========================================
+ Coverage 94.48% 94.54% +0.06%
==========================================
Files 113 113
Lines 25172 25173 +1
Branches 2499 2499
==========================================
+ Hits 23783 23801 +18
+ Misses 1059 1047 -12
+ Partials 330 325 -5
Continue to review full report at Codecov.
|
nicoddemus
reviewed
Mar 3, 2019
nicoddemus
approved these changes
Mar 3, 2019
Contributor
Author
|
It was not failing on CI anymore, but looked like it was not covered. added a todo for diff coverage. But maybe it would be better to just monkeypatch |
Member
Hmm that's an idea. Let's see, if this gets flaky we might go down that route, otherwise I'm fine with the code as it is. |
It fails reliable for me now without the fix from 9517c3a. Ref: pytest-dev#2370
blueyed
force-pushed
the
fix-test_crash_on_closing_tmpfile_py27
branch
from
9e8496d to
83558a0
Compare
Contributor
Author
|
Ok, squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fails reliable for me now without the fix from 9517c3a, and had
actually a wrong assertion in the end.
Ref: #2370