Skip to content

tox: split default posargs, use --lsof with single job only#4847

Merged
blueyed merged 2 commits intopytest-dev:masterfrom
blueyed:tox-posargs-lsof
Mar 1, 2019
Merged

tox: split default posargs, use --lsof with single job only#4847
blueyed merged 2 commits intopytest-dev:masterfrom
blueyed:tox-posargs-lsof

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 27, 2019 •
edited
Loading

This is required for combining.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 27, 2019

The plan is to use lsof with only a few jobs.
This should now not use it all, and hopefully codecov will show.

@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited
Loading

Codecov Report

Merging #4847 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4847      +/-   ##
==========================================
- Coverage   94.29%   93.17%   -1.12%     
==========================================
  Files         113      113              
  Lines       25172    25172              
  Branches     2499     2499              
==========================================
- Hits        23735    23455     -280     
- Misses       1100     1379     +279     
- Partials      337      338       +1
Impacted Files Coverage Δ
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 33.33% <0%> (-41.67%) ⬇️
src/_pytest/debugging.py 44.02% <0%> (-13.21%) ⬇️
testing/test_conftest.py 90.33% <0%> (-9.3%) ⬇️
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
testing/test_pdb.py 40.27% <0%> (-7.88%) ⬇️
src/_pytest/pytester.py 80.51% <0%> (-5.84%) ⬇️
testing/python/integration.py 86.52% <0%> (-4.97%) ⬇️
testing/test_collection.py 95.22% <0%> (-4.59%) ⬇️
testing/test_tmpdir.py 94.62% <0%> (-4.31%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd4cb0...f8160f7. Read the comment docs.

@nicoddemus
Copy link
Member

nicoddemus commented Feb 27, 2019

This should now not use it all, and hopefully codecov will show.

You think lsof was the cause for the timeouts?

I can reach codecov by clicking on the image (https://codecov.io/gh/pytest-dev/pytest/pull/4847?src=pr&el=tree), but all other links still time out to me.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 27, 2019

You think lsof was the cause for the timeouts?

No, I've meant that it will show missing coverage.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 27, 2019

I will compare it manually/rebase it when codecov works again.

@nicoddemus
Copy link
Member

nicoddemus commented Feb 27, 2019

OK, thanks!

@blueyed blueyed changed the title WIP: tox: lsof factor, split default posargs tox: lsof factor, split default posargs Feb 27, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Feb 27, 2019

Waiting for codecov status.
Good according to https://codecov.io/github/pytest-dev/pytest/commit/3452460090c7233a78baed6557a65af432b2422f.

@blueyed blueyed closed this Feb 27, 2019
@blueyed blueyed reopened this Feb 27, 2019
@blueyed blueyed requested a review from nicoddemus February 27, 2019 17:35
nicoddemus
nicoddemus requested changes Feb 27, 2019
View reviewed changes
@blueyed
Copy link
Contributor Author

blueyed commented Feb 28, 2019

@nicoddemus
Changed/simplified, please re-review.

@blueyed blueyed changed the title tox: lsof factor, split default posargs tox: split default posargs, use --lsof with single job only Feb 28, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Feb 28, 2019

Needs the fix from #4851, i.e. should also get done against features then.

@blueyed blueyed changed the title tox: split default posargs, use --lsof with single job only WIP: tox: split default posargs, use --lsof with single job only Feb 28, 2019
@blueyed blueyed force-pushed the tox-posargs-lsof branch from 7c42ece to 9186d62 Compare March 1, 2019 15:49
@blueyed
tox: split default posargs in multiple env vars
f0d7773 
This is required for combining.

Use it for new lsof facor also.
@blueyed blueyed force-pushed the tox-posargs-lsof branch from 9186d62 to baf4e5c Compare March 1, 2019 15:51
@blueyed
Copy link
Contributor Author

blueyed commented Mar 1, 2019

Backed out to previous 9186d62 and rebased (due to the PYTEST_ADDOPTS issue).
I would like to use the lsof factor with #4865 then.

@blueyed blueyed changed the title WIP: tox: split default posargs, use --lsof with single job only tox: split default posargs, use --lsof with single job only Mar 1, 2019
@blueyed blueyed force-pushed the tox-posargs-lsof branch from baf4e5c to f8160f7 Compare March 1, 2019 16:00
blueyed
blueyed commented Mar 1, 2019
View reviewed changes
.travis.yml
- stage: baseline
env: TOXENV=py27-pexpect,py27-trial
- env: TOXENV=py37-numpy-xdist
- env: TOXENV=py37-lsof-numpy-xdist PYTEST_COVERAGE=1
Copy link
Contributor Author

@blueyed blueyed Mar 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that lsof is only used to cover the code for it (we do not react / handle its warnings anyway), this could also be done with a faster job for less overhead maybe.

@blueyed blueyed merged commit 90031ed into pytest-dev:master Mar 1, 2019
@blueyed blueyed deleted the tox-posargs-lsof branch March 1, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @nicoddemus