Codecov Report

Merging #4800 into master will decrease coverage by 4.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4800      +/-   ##
==========================================
- Coverage   95.64%   91.61%   -4.03%     
==========================================
  Files         113      113              
  Lines       25054    25054              
  Branches     2488     2353     -135     
==========================================
- Hits        23963    22954    -1009     
- Misses        769     1687     +918     
- Partials      322      413      +91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2106515...98d61a3. Read the comment docs.

Report was uploaded: https://codeclimate.com/repos/5bf9a4be8d88b928f6000b35/settings/test_reports/5c65a8f25ce3550257009a03

Activated PR status updates at https://codeclimate.com/repos/5bf9a4be8d88b928f6000b35/settings/github/edit.

I'm really not a fan of codeclimate -- for a lot of the same reasons I don't use pylint (which seems to power a lot of its suggestions)

here's an example useless suggestion: https://codeclimate.com/github/pytest-dev/pytest/pull/4804

I'm fine using it to replace coveralls / codecov, but please turn off the rest of it <3

I'm on the fence here. I lean towards @asottile suggestion that most of the suggestions are not really useful, but I'm OK with we activating it and see how it goes. A month or two later we then decide if we want to keep using it (and taking the suggestions seriously) or just drop it altogether.

What do you guys think?

If the first time a long error is brought up is after the PR is created that's way too late, especially if the error isn't actionable.

If the first time a long error is brought up is after the PR is created that's way too late, especially if the error isn't actionable.

So you are 👎 on adding it in a provisional state?

If we can get the coverage bits without any of the rest of it that's great :)

Let's hear what @blueyed has to say then. 👍

Yeah, only added it for coverage mainly - which cannot be used alone it seems.
The status is not required, so should be OK.

I fear it'll be confusing for newcomers and annoying to have all of our PRs red. I definitely use the PR icon as to whether to look at something or not

I've pinged Codeclimate support about this (only having coverage related things cause a red X).