Skip to content

Run docs, doctesting and linting in the same job to save some CI time#4125

Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus:docs-baseline
Oct 13, 2018
Merged

Run docs, doctesting and linting in the same job to save some CI time#4125
nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus:docs-baseline

Conversation

@nicoddemus
Copy link
Copy Markdown
Member

Docs also checks the documentation for syntax failures, so it should
part of the baseline to bail out early.

@nicoddemus
Copy link
Copy Markdown
Member Author

nicoddemus commented Oct 12, 2018

The [skip appveyor] in the commit message prevents AppVeyor from triggering a build, given that this PR only affects Travis anyway.

@blueyed
Copy link
Copy Markdown
Contributor

blueyed commented Oct 12, 2018

@nicoddemus
With regard to builds: any idea why Travis is queuing two builds per PR?
And are you or somebody else manually canceling the duplicate then? (which appears to affect the PR on Github then already)

Comment thread .travis.yml Outdated
@nicoddemus
Copy link
Copy Markdown
Member Author

And are you or somebody else manually canceling the duplicate then?

I'm not doing anything, but what do you mean it is queuing two builds per PR? I only see a single build per PR in the dashboard: https://travis-ci.org/pytest-dev/pytest/pull_requests

We have configured Travis to cancel running jobs if new commits are pushed to a branch, but it shouldn't be triggering two builds per PR.

@nicoddemus
Copy link
Copy Markdown
Member Author

Hmmm you mean this?

image

@blueyed
Copy link
Copy Markdown
Contributor

blueyed commented Oct 12, 2018

Yes.

Comment thread .travis.yml Outdated
@nicoddemus
Copy link
Copy Markdown
Member Author

No idea what could be causing the duplicated jobs... 🤔

@nicoddemus nicoddemus changed the title Add docs env to baseline [skip appveyor] Run docs, doctesting and linting in the same job to save some CI time Oct 12, 2018
@nicoddemus
Copy link
Copy Markdown
Member Author

Decided to do the same thing for AppVeyor to avoid the cost of spinning a new VM for what is essentially the same job.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 93.801% when pulling 2dc619c on nicoddemus:docs-baseline into d46b6b2 on pytest-dev:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 12, 2018

Coverage Status

Coverage increased (+0.05%) to 93.826% when pulling 2dc619c on nicoddemus:docs-baseline into d46b6b2 on pytest-dev:master.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2018

Codecov Report

Merging #4125 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4125      +/-   ##
==========================================
- Coverage   94.49%   94.49%   -0.01%     
==========================================
  Files         109      109              
  Lines       23813    23813              
  Branches     2349     2349              
==========================================
- Hits        22502    22501       -1     
- Misses       1003     1004       +1     
  Partials      308      308
Flag Coverage Δ
#doctesting ?
#linux 94.34% <ø> (-0.01%) ⬇️
#nobyte 0% <ø> (ø) ⬆️
#numpy 28.15% <ø> (+0.06%) ⬆️
#pexpect 0% <ø> (ø) ⬆️
#py27 92.66% <ø> (+0.04%) ⬆️
#py34 92.11% <ø> (+0.03%) ⬆️
#py35 92.12% <ø> (+0.03%) ⬆️
#py36 92.69% <ø> (+0.04%) ⬆️
#py37 92.33% <ø> (+0.03%) ⬆️
#trial 31.38% <ø> (+0.06%) ⬆️
#windows 93.79% <ø> (-0.05%) ⬇️
#xdist 18.57% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
src/_pytest/assertion/util.py 92.92% <0%> (-5.19%) ⬇️
src/_pytest/terminal.py 91.62% <0%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46b6b2...2dc619c. Read the comment docs.

@nicoddemus nicoddemus merged commit eabf15b into pytest-dev:master Oct 13, 2018
@nicoddemus nicoddemus deleted the docs-baseline branch October 13, 2018 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants