Skip to content

Update usefixtures documentation#4121

Merged
crazymerlyn merged 1 commit intopytest-dev:masterfrom
labcodes:3713
Oct 12, 2018
Merged

Update usefixtures documentation#4121
crazymerlyn merged 1 commit intopytest-dev:masterfrom
labcodes:3713

Conversation

@cacoze
Copy link
Copy Markdown
Contributor

@cacoze cacoze commented Oct 12, 2018

Fixes #3713

Clarifying that it can't be used with fixture functions
@cacoze cacoze changed the title Update usefixtures documentation to clarify that it can't be used wit… Update usefixtures documentation Oct 12, 2018
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 93.801% when pulling dbaa946 on labcodes:3713 into 0f5263c on pytest-dev:master.

Copy link
Copy Markdown
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacoze!

@crazymerlyn crazymerlyn merged commit d46b6b2 into pytest-dev:master Oct 12, 2018
@nicoddemus
Copy link
Copy Markdown
Member

Hey @crazymerlyn, thanks for merging this, just a friendly heads-up: in general we should wait for the CI to finish, even for documentation changes. Our docs tox environment checks for documentation errors, so it may fail the build if there are syntax errors in the .rst (for example).

Of course this change is trivial, but it is good to avoid exceptions to the protocol. 😁

@crazymerlyn
Copy link
Copy Markdown
Member

@nicoddemus Thanks for the heads up. Will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants