Use inspect to properly detect generators. Fixes #2129#2130
Use inspect to properly detect generators. Fixes #2129#2130nicoddemus merged 4 commits intopytest-dev:masterfrom
Conversation
|
With this fix, gist (https://gist.github.com/malinoff/148507bf51ff8b9a0a947c178aa0ac3a) output is |
|
Errors do not seem to be related to my change. |
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
the technical details are well done
i'd like for someone else to have a second look at the ramifications of the asyncio import and merge
thanks 👍
|
Thanks @malinoff and @RonnyPfannschmidt, I will take a more detailed look at the PR and the CI errors but probably will only have time for it later in the week though. |
This avoids having to resort to skipping modules in conftest.py file and avoids flake8 errors
|
I pushed some commits to the PR:
Thanks again to @malinoff for pursuing this. 👍 |
|
Hmmm now |
|
@nicoddemus could you please merge this? |
|
@malinoff I would like to take a look at the trial failures first. While they seem unrelated, I'm not sure. Are you using pytest in development mode? |
|
The trial failures are certainly unrelated since they are happening on Thanks @malinoff for the patience! 🙇 |
|
Yay! Thanks @nicoddemus |
AUTHORS;CHANGELOG.rstCHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.