Fix false-positive assert rewrite warnings when using 'pytest_plugins'#2110
Merged
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom Dec 1, 2016
Merged
Conversation
pytest would emit false positive warnings about assertion-rewrite when a module appears multiple times in plugins which depend on other plugins using the 'pytest_plugins' mechanism
Member
|
\o/ that one was the blocker i found in our production env that i couldn't identify, awesome :) now i can update to pytest 3.0.x for that repo |
Member
Author
|
Cool! 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest would emit false-positive warnings about assertion-rewrite when a module appears multiple times in plugins which depend on other plugins using the
pytest_pluginsmechanism.Here's the output of the test added by this PR on
master: