Add test case for #595.#2091
Add test case for #595.#2091nicoddemus merged 1 commit intopytest-dev:masterfrom decentral1se:move-595-along
Conversation
|
CI failure related to #2087 (comment). |
| result, dom = runandparse(testdir) | ||
| assert result.ret == 0 | ||
| node = dom.find_first_by_tag("testsuite") | ||
| assert not node.find_first_by_tag("system-out") |
There was a problem hiding this comment.
To be safer, perhaps it would be better to also assert that "bar!" doesn't appear on the entire XML text?
|
Failure is related to: pypa/setuptools#861. |
|
Could you improve the test like I commented and rebase on |
|
Fixed up the test and rebased on master 👍 |
This new test proves that reports do not capture stdout by default when skipped.
|
So it seems at some point the issue on #595 is no longer a problem. Not sure at which point that happened though. |
|
I say we close the original issue as "fixed" and don't bother with a new flag to restore the previous behavior because so far nobody complained (also it seems the original behavior was an accident rather than intentional). |
Sounds good to me. Feel free to do whatever with this test. |
|
It should be merged, it is only asserting existing behavior. 😁 |
|
🍻 |
3 participants
Something to move the conversation on #595 along.
@davidszotten said in #595:
So far as I can tell, my test shows that the output of a skipped test is not captured by default.
Is this already fixed or I missed something?