Skip to content

Add :ref: targets to recwarn.rst.#2087

Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom
decentral1se:ref-recwarns
Nov 26, 2016
Merged

Add :ref: targets to recwarn.rst.#2087
nicoddemus merged 1 commit intopytest-dev:masterfrom
decentral1se:ref-recwarns

Conversation

@decentral1se
Copy link
Copy Markdown
Contributor

@decentral1se decentral1se commented Nov 26, 2016 •
edited
Loading

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 26, 2016

Coverage Status

Coverage remained the same at 92.819% when pulling e71bc77 on lwm:ref-recwarns into 33796c8 on pytest-dev:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 26, 2016

Coverage Status

Coverage remained the same at 92.819% when pulling 2a29c68 on lwm:ref-recwarns into 33796c8 on pytest-dev:master.

@decentral1se
Copy link
Copy Markdown
Contributor Author

decentral1se commented Nov 26, 2016 •
edited
Loading

CI failure seems unrelated (see report), given that #2088 and #2085 also had similar failures.

@decentral1se decentral1se mentioned this pull request Nov 26, 2016
Merged
@nicoddemus
Copy link
Copy Markdown
Member

nicoddemus commented Nov 26, 2016

CI failure seems unrelated (see report), given that #2088 and #2085 also had similar failures.

Agree, I will take a look.

@nicoddemus
Copy link
Copy Markdown
Member

nicoddemus commented Nov 26, 2016

Failure related to: pypa/setuptools#861

@nicoddemus
Copy link
Copy Markdown
Member

nicoddemus commented Nov 26, 2016

Greetings from Zagreb!

Greetings! No wonder there's been so much activity today! 😆

We really appreciate the efforts!

nicoddemus
nicoddemus requested changes Nov 26, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to the CHANGELOG note. Other than that LGTM.

Could you also rebase on master please? Thanks!

Comment thread CHANGELOG.rst Outdated
3.0.5.dev0
==========

* Provide `:ref:` targets for `recwarn.rst` so we can use intersphinx referencing.
Copy link
Copy Markdown
Member

@nicoddemus nicoddemus Nov 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use double ` for mono space text in RST:

Provide ``:ref:`` targets for ``recwarn.rst`` so we can use intersphinx referencing.

@decentral1se
Copy link
Copy Markdown
Contributor Author

decentral1se commented Nov 26, 2016

Greetings from Zagreb!

Greetings! No wonder there's been so much activity today! 😆
We really appreciate the efforts!

Happy to help 🍻

Fixed up CHANGELOG.rst based on your comment and rebased on master.

Thanks for clearing up issue with #2092.

@nicoddemus
Copy link
Copy Markdown
Member

nicoddemus commented Nov 26, 2016

Nice! As soon as CI passes I will merge this!

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 26, 2016

Coverage Status

Coverage remained the same at 92.819% when pulling 1aa5bfe on lwm:ref-recwarns into a6084ed on pytest-dev:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 26, 2016

Coverage Status

Coverage remained the same at 92.819% when pulling 1aa5bfe on lwm:ref-recwarns into a6084ed on pytest-dev:master.

@nicoddemus nicoddemus merged commit 8138d88 into pytest-dev:master Nov 26, 2016
@decentral1se decentral1se deleted the ref-recwarns branch November 27, 2016 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@decentral1se @coveralls @nicoddemus